[dpdk-dev] [PATCH v1] metrics: fix Coverity warnings

[dpdk-dev] [PATCH v1] metrics: fix Coverity warnings

[Remy Horton]

Fixes memory access errors detected by Coverity.
All cases are the maximum permissable value causing an
out-by-one overrun.

Coverity issue 143433: Memory - illigal access
Coverity issue 143434: Memory - illigal access
Coverity issue 143460: Memory - corruptins
Coverity issue 143464: Memory - illigal access

Fixes: 349950ddb9c5 ("metrics: add information metrics library")

Signed-off-by: Remy Horton <remy.horton@intel.com>
---
 lib/librte_metrics/rte_metrics.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c
index e9a122c..6e61f9b 100644
--- a/lib/librte_metrics/rte_metrics.c
+++ b/lib/librte_metrics/rte_metrics.c
@@ -51,7 +51,7 @@
  */
 struct rte_metrics_meta_s {
 	/** Name of metric */
-	char name[RTE_METRICS_MAX_NAME_LEN];
+	char name[RTE_METRICS_MAX_NAME_LEN + 1];
 	/** Current value for metric */
 	uint64_t value[RTE_MAX_ETHPORTS];
 	/** Used for global metrics */
@@ -176,7 +176,7 @@ rte_metrics_update_values(int port_id,
 	uint16_t cnt_setsize;
 
 	if (port_id != RTE_METRICS_GLOBAL &&
-			(port_id < 0 || port_id > RTE_MAX_ETHPORTS))
+			(port_id < 0 || port_id >= RTE_MAX_ETHPORTS))
 		return -EINVAL;
 
 	if (values == NULL)
@@ -263,7 +263,7 @@ rte_metrics_get_values(int port_id,
 	int return_value;
 
 	if (port_id != RTE_METRICS_GLOBAL &&
-			(port_id < 0 || port_id > RTE_MAX_ETHPORTS))
+			(port_id < 0 || port_id >= RTE_MAX_ETHPORTS))
 		return -EINVAL;
 
 	memzone = rte_memzone_lookup(RTE_METRICS_MEMZONE_NAME);
-- 
2.5.5

Re: [dpdk-dev] [PATCH v1] metrics: fix Coverity warnings

[Thomas Monjalon]

11/05/2017 14:53, Remy Horton:
> Fixes memory access errors detected by Coverity.
> All cases are the maximum permissable value causing an
> out-by-one overrun.
> 
> Coverity issue 143433: Memory - illigal access
> Coverity issue 143434: Memory - illigal access
> Coverity issue 143460: Memory - corruptins
> Coverity issue 143464: Memory - illigal access
> 
> Fixes: 349950ddb9c5 ("metrics: add information metrics library")
> 
> Signed-off-by: Remy Horton <remy.horton@intel.com>

Applied, thanks