From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 9EB3C5686 for ; Wed, 14 Jan 2015 16:29:52 +0100 (CET) Received: by mail-wg0-f47.google.com with SMTP id n12so9600626wgh.6 for ; Wed, 14 Jan 2015 07:29:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=owr7Mt7XMxRSNCiP+9SceGmOa9e87zBl+uZrUpjVAkg=; b=IAoj83AgmuFPCY6Ml5TfdVOa3GYtXHbU765ryRvjZZT4PKSuQa2kfn4acNzv6CSoOA xfbhIGHA7azU9OQyjGapZMQfrvL/4ylrdbTYWyWXO0O4NfuZPLzE+A/9UGdki/RNpXhn B0zoejFZ6b00s6M+4hKsHgO2tRVj9uYtNEqrFYmcsZY5tmOSdQOGTD7aX81NSB3Hyh97 WoWofowuG+n9D3wxpIi9riv12jog39YjYJtBibl0JibLSXc+KqzQ59qOoJsxc7aoOEXA YOclsljO2UH33NqOYsc7IMk4DDU09avL261Wvs/T3ewy62ZJCgvh2KC3KjHJf2LaDoen UPnA== X-Gm-Message-State: ALoCoQmWZBbEmbbFk+su0RenD6poBoyS5a3P0E+RoYLDq6q/dvIQCQQVsirSTB6EYkSZB9Xck219 X-Received: by 10.194.187.79 with SMTP id fq15mr8636971wjc.2.1421249392426; Wed, 14 Jan 2015 07:29:52 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id o1sm30504830wjf.41.2015.01.14.07.29.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Jan 2015 07:29:51 -0800 (PST) From: Thomas Monjalon To: Neil Horman Date: Wed, 14 Jan 2015 16:29:29 +0100 Message-ID: <1996722.WEmzGEN7VB@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1419349913-21674-2-git-send-email-nhorman@tuxdriver.com> References: <1419109299-9603-1-git-send-email-nhorman@tuxdriver.com> <1419349913-21674-1-git-send-email-nhorman@tuxdriver.com> <1419349913-21674-2-git-send-email-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 2/4] Provide initial versioning for all DPDK libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jan 2015 15:29:53 -0000 2014-12-23 10:51, Neil Horman: > Add linker version script files to each DPDK library to put a stake in the > ground from which we can start cleaning up API's [...] > lib/librte_acl/Makefile | 2 + > lib/librte_acl/rte_acl_version.map | 21 ++++ > lib/librte_cfgfile/Makefile | 2 + > lib/librte_cfgfile/rte_cfgfile_version.map | 14 +++ > lib/librte_cmdline/Makefile | 2 + > lib/librte_cmdline/rte_cmdline_version.map | 69 +++++++++++++ > lib/librte_distributor/Makefile | 2 + > lib/librte_distributor/rte_distributor_version.map | 16 +++ > lib/librte_eal/bsdapp/eal/Makefile | 2 + > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 90 ++++++++++++++++ > lib/librte_eal/linuxapp/eal/Makefile | 2 + > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 90 ++++++++++++++++ > lib/librte_ether/Makefile | 2 + > lib/librte_ether/rte_ether_version.map | 113 +++++++++++++++++++++ > lib/librte_hash/Makefile | 2 + > lib/librte_hash/rte_hash_version.map | 18 ++++ > lib/librte_ip_frag/Makefile | 2 + > lib/librte_ip_frag/rte_ipfrag_version.map | 14 +++ > lib/librte_ivshmem/Makefile | 2 + > lib/librte_ivshmem/rte_ivshmem_version.map | 13 +++ > lib/librte_kni/Makefile | 2 + > lib/librte_kni/rte_kni_version.map | 20 ++++ > lib/librte_kvargs/Makefile | 2 + > lib/librte_kvargs/rte_kvargs_version.map | 10 ++ > lib/librte_lpm/Makefile | 2 + > lib/librte_lpm/rte_lpm_version.map | 24 +++++ > lib/librte_malloc/Makefile | 2 + > lib/librte_malloc/rte_malloc_version.map | 19 ++++ > lib/librte_mbuf/Makefile | 2 + > lib/librte_mbuf/rte_mbuf_version.map | 14 +++ > lib/librte_mempool/Makefile | 2 + > lib/librte_mempool/rte_mempool_version.map | 18 ++++ > lib/librte_meter/Makefile | 2 + > lib/librte_meter/rte_meter_version.map | 13 +++ > lib/librte_pipeline/Makefile | 2 + > lib/librte_pipeline/rte_pipeline_version.map | 23 +++++ > lib/librte_pmd_af_packet/Makefile | 2 + > .../rte_pmd_af_packet_version.map | 7 ++ > lib/librte_pmd_bond/Makefile | 2 + > lib/librte_pmd_bond/rte_eth_bond_version.map | 21 ++++ > lib/librte_pmd_e1000/Makefile | 2 + > lib/librte_pmd_e1000/rte_pmd_e1000_version.map | 5 + > lib/librte_pmd_enic/Makefile | 2 + > lib/librte_pmd_enic/rte_pmd_enic_version.map | 5 + > lib/librte_pmd_i40e/Makefile | 2 + > lib/librte_pmd_i40e/rte_pmd_i40e_version.map | 5 + > lib/librte_pmd_ixgbe/Makefile | 2 + > lib/librte_pmd_ixgbe/rte_pmd_ixgbe_version.map | 5 + > lib/librte_pmd_pcap/Makefile | 2 + > lib/librte_pmd_pcap/rte_pmd_pcap_version.map | 5 + > lib/librte_pmd_ring/Makefile | 2 + > lib/librte_pmd_ring/rte_eth_ring.c | 2 +- > lib/librte_pmd_ring/rte_eth_ring.h | 6 -- > lib/librte_pmd_ring/rte_eth_ring_version.map | 10 ++ > lib/librte_pmd_virtio/Makefile | 1 + > lib/librte_pmd_virtio/rte_pmd_virtio_version.map | 5 + > lib/librte_pmd_vmxnet3/Makefile | 2 + > lib/librte_pmd_vmxnet3/rte_pmd_vmxnet3_version.map | 5 + > lib/librte_pmd_xenvirt/Makefile | 2 + > lib/librte_pmd_xenvirt/rte_eth_xenvirt_version.map | 8 ++ > lib/librte_port/Makefile | 2 + > lib/librte_port/rte_port_version.map | 18 ++++ > lib/librte_power/Makefile | 2 + > lib/librte_power/rte_power_version.map | 18 ++++ > lib/librte_ring/Makefile | 2 + > lib/librte_ring/rte_ring_version.map | 12 +++ > lib/librte_sched/Makefile | 2 + > lib/librte_sched/rte_sched_version.map | 22 ++++ > lib/librte_table/Makefile | 2 + > lib/librte_table/rte_table_version.map | 22 ++++ > lib/librte_timer/Makefile | 2 + > lib/librte_timer/rte_timer_version.map | 16 +++ > lib/librte_vhost/Makefile | 2 + > lib/librte_vhost/rte_vhost_version.map | 14 +++ Honestly, this patch is difficult to review. How have you populated .map files? Did you use some script? [...] > --- a/mk/rte.lib.mk > +++ b/mk/rte.lib.mk > -CPU_LDFLAGS += --version-script=$(EXPORT_MAP) > +CPU_LDFLAGS += --version-script=$(SRCDIR)/$(EXPORT_MAP) I guess this change should go in patch 1 which introduced this option. -- Thomas