From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 13FC91B29E for ; Sun, 4 Feb 2018 16:07:22 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A125E211FB; Sun, 4 Feb 2018 10:07:21 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 04 Feb 2018 10:07:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=XyuDaxLgenvUvG7Q6LGCS4TG0U LLfixLlZWOxyXN+2U=; b=lX69V6lPlr64ckJBMWMZt+4wGRBivvc7GrB5oeb/Qs luJzYhG+zt7383pA/vEpuHBVBUyHwHmvR+Bgi5MI7DuEspaYM4DfBO4rnA8/+N45 pJZoA56LsaVHjLWn4wqDVHbnfRQB7uhGDQl9NM7SffjVMhxzbw5aCZuchFYQJw8n c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XyuDax LgenvUvG7Q6LGCS4TG0ULLfixLlZWOxyXN+2U=; b=iLSzVlBxQk7Yy1mmRoFsOS OvgI6NBBessLsVXFOqdw6WUWfH+BnJA48iIHbbQJoTHlwAhkQpUfiaUyD7oIls0E Exu2uBv+ZNgQdgv8tCti5MQgBTOc8GrnEDczva3eOS2lFn2VF9kJkTePEn9AeTfE eLhnlIXfoOq6vE5xLf6YVLzRfoJEvWupYv36rieoRXPba3rz9L8BTFzib+N//SuF kL4BKddgpVjimIVAnNJOIPAtg7qtnGgWdYK52GUjx3uvDezcdu1gbDzkUAvHHb92 2u2F63a3TgAigB1OrZhEoT86grsF7iXfR2gfzv73znY/nQLCxAqG4p7jMCN7T4JQ == X-ME-Sender: Received: from xps.localnet (6.42.136.77.rev.sfr.net [77.136.42.6]) by mail.messagingengine.com (Postfix) with ESMTPA id 345D17E4EC; Sun, 4 Feb 2018 10:07:21 -0500 (EST) From: Thomas Monjalon To: Fiona Trahe Cc: dev@dpdk.org, ahmed.mansour@nxp.com, Shally.Verma@cavium.com, pablo.de.lara.guarch@intel.com Date: Sun, 04 Feb 2018 15:24:40 +0100 Message-ID: <1997769.o2qW9LT7Ur@xps> In-Reply-To: <1517595924-25963-1-git-send-email-fiona.trahe@intel.com> References: <1517595924-25963-1-git-send-email-fiona.trahe@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] compressdev: implement API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Feb 2018 15:07:22 -0000 02/02/2018 19:25, Fiona Trahe: > config/common_base | 6 + > doc/api/doxy-api-index.md | 1 + > doc/api/doxy-api.conf | 1 + > lib/Makefile | 3 + > lib/librte_compressdev/Makefile | 29 + > lib/librte_compressdev/rte_comp.h | 503 ++++++++++++ Why rte_comp.h instead of the more consistent rte_compress.h? > lib/librte_compressdev/rte_compressdev.c | 902 +++++++++++++++++++++ > lib/librte_compressdev/rte_compressdev.h | 757 +++++++++++++++++ > lib/librte_compressdev/rte_compressdev_pmd.c | 163 ++++ > lib/librte_compressdev/rte_compressdev_pmd.h | 439 ++++++++++ > lib/librte_compressdev/rte_compressdev_version.map | 47 ++ > lib/librte_eal/common/include/rte_log.h | 1 + > mk/rte.app.mk | 1 + > 13 files changed, 2853 insertions(+) Please update MAINTAINERS file and release notes. Maybe it is worth splitting this patch in few shorter parts? > --- a/config/common_base > +++ b/config/common_base > @@ -535,6 +535,12 @@ CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO=n > CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO_DEBUG=n > > # > +# Compile generic compression device library > +# > +CONFIG_RTE_LIBRTE_COMPRESSDEV=y > +CONFIG_RTE_COMPRESS_MAX_DEVS=64 > + > +# > # Compile generic security library > # > CONFIG_RTE_LIBRTE_SECURITY=y > diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md > index d77f205..07b8e75 100644 > --- a/doc/api/doxy-api-index.md > +++ b/doc/api/doxy-api-index.md > @@ -43,6 +43,7 @@ The public API headers are grouped by topics: > [rte_tm] (@ref rte_tm.h), > [rte_mtr] (@ref rte_mtr.h), > [bbdev] (@ref rte_bbdev.h), > + [compressdev] (@ref rte_compressdev.h), > [cryptodev] (@ref rte_cryptodev.h), > [security] (@ref rte_security.h), > [eventdev] (@ref rte_eventdev.h), Please move it between security and eventdev in these lists.