From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 54E2F8E81 for ; Sun, 13 Dec 2015 00:56:20 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id p66so1192650wmp.0 for ; Sat, 12 Dec 2015 15:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=S/I02gzjkNGKyOgjKhFNg/nDpJYhUJVRJNS0e6xXsaQ=; b=WlY+vw8TsHYBy1zvkGIPVWzkttpHFtFdiH79E1BdYEjjy1R0txj+C4Gt6SZqIQOHo+ MzRfya2g54picaL9hxPmLs7r3NujTzdFNePOSun3CpDSSUbnBLYj1DTh2QdR4+wUYj5f rCeC0fSYP9IQboQlzbOa93eL9PlczZsbBRWn+nFbAzYYTDpu4xY507kiSJYWXlYd4okD ECvQNL9crdLIZLHoxN8LroN54m5oLs1IxIKwn8EHatMrI/Dl9ClRfrq6t8PHHsu3FmiK hrZVT9uVzqxtdujO10lidJxRBWoZWtEcejrZ8FPQikigNs+zQ1Vd8R+AAk+b4J76MtkO IV3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=S/I02gzjkNGKyOgjKhFNg/nDpJYhUJVRJNS0e6xXsaQ=; b=X/s9/dVQvoh7ZKn98NgcRLdH2fskmAAZUmiOmMmfNY4Jd3XT+MeEooELYpMWU9XxIj mTt8aqM7gExhgcbHaG8L2s+BMd9cJUyk1BqUac1mhix0+7+gjFd5GSlGUxQA+hhlGURU M6NdHHW3xOjD6Yakb2BO4HjjFYpZVK9tLlUL0gp56O6m7WzLsuAAJBMoaBc8MERF0FyL e35wyFSneO28II0VgfHk+R1pvE4X+nEGOeXcrxLVa03mee13P+FwGR1tMmK9CBYQ1klE YBC4RRwnSEqviFZ8fxPEC/7seidBA39u0pF3WFUDfEPU2fEXOCmTleF63sg05wZxJyXW wZ8g== X-Gm-Message-State: ALoCoQk6Tkuymv4BVkDliijYWgSz2Esq+2hiHmvwC+G3ekaI6i7kVcuQTOW4EMjk7GXDCKqe64pw3lSnuoKT7T7RuqiQQp69OA== X-Received: by 10.194.179.71 with SMTP id de7mr28132194wjc.119.1449964580172; Sat, 12 Dec 2015 15:56:20 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id 193sm9483328wmp.16.2015.12.12.15.56.18 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 12 Dec 2015 15:56:19 -0800 (PST) From: Thomas Monjalon To: Rahul Lakkireddy Date: Sun, 13 Dec 2015 00:55:03 +0100 Message-ID: <1999328.glrlqgBIyh@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <66655e2d7666da09b80174d265eef304b8d93470.1449821728.git.rahul.lakkireddy@chelsio.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Felix Marti , Nirranjan Kirubaharan , Kumar Sanghvi Subject: Re: [dpdk-dev] [PATCH] cxgbe: fix unnecessary check for freelist existence while freeing rxq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Dec 2015 23:56:20 -0000 > > When refilling freelists for the first time and if it fails, the rxq is > > freed and returns ENOMEM. There is a check while freeing hardware rxq to > > pass freelist context id if the freelist exists or 0xffff otherwise. > > The error path is only reached if freelist exists. So, fix is to remove > > the useless check for freelist existence. > > > > Thanks to John McNamara for reporting it. > > > > Coverity issue: 107108 > > Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support") > > > > Signed-off-by: Rahul Lakkireddy > > Signed-off-by: Kumar Sanghvi > > Thanks for updating the Coverity Triage for the issue. > > Acked-by: John McNamara Applied, thanks