From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jie Wang <jie1x.wang@intel.com>, <dev@dpdk.org>
Cc: <xiaoyun.li@intel.com>, <andrew.rybchenko@oktetlabs.ru>,
<thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v8 1/2] ethdev: add an API to get device configuration info
Date: Wed, 8 Sep 2021 17:46:00 +0100 [thread overview]
Message-ID: <19ad2d4c-1d66-5a65-ad3e-e366bb461a16@intel.com> (raw)
In-Reply-To: <20210827081740.365037-2-jie1x.wang@intel.com>
On 8/27/2021 9:17 AM, Jie Wang wrote:
> This patch adds a new API "rte_eth_dev_conf_info_get()" to help users get
> device configuration info.
>
> Signed-off-by: Jie Wang <jie1x.wang@intel.com>
> ---
> lib/ethdev/rte_ethdev.c | 28 ++++++++++++++++++++++++++++
> lib/ethdev/rte_ethdev.h | 21 +++++++++++++++++++++
> lib/ethdev/version.map | 3 +++
> 3 files changed, 52 insertions(+)
>
Can you add a release notes update for this?
> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
> index 9d95cd11e1..bbe24af662 100644
> --- a/lib/ethdev/rte_ethdev.c
> +++ b/lib/ethdev/rte_ethdev.c
> @@ -3458,6 +3458,34 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info)
> return 0;
> }
>
> +int
> +rte_eth_dev_conf_info_get(uint16_t port_id,
> + struct rte_eth_conf *dev_conf_info)
> +{
> + struct rte_eth_dev *dev;
> +
> + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
> + dev = &rte_eth_devices[port_id];
> +
> + if (dev_conf_info == NULL) {
> + RTE_ETHDEV_LOG(ERR, "Cannot get ethdev port %u configuration info to NULL\n",
Can you break the line after 'ERR', to reduce the column length?
> + port_id);
> + return -EINVAL;
> + }
> +
> + /*
> + * Init dev_conf_info before port_id check since caller does not have
> + * return status and does not know if get is successful or not.
> + */
> + memset(dev_conf_info, 0, sizeof(struct rte_eth_conf));
> +
I didn't get the reasoning for the memset, won't it be overwriten anyway by
below 'memcpy'?
> + /* copy dev->data->dev_conf to dev_conf_info */
> + memcpy(dev_conf_info, &dev->data->dev_conf,
> + sizeof(struct rte_eth_conf));
> +
> + return 0;
> +}
> +
> int
> rte_eth_dev_get_supported_ptypes(uint16_t port_id, uint32_t ptype_mask,
> uint32_t *ptypes, int num)
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> index d2b27c351f..3c5b02a133 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -3058,6 +3058,27 @@ int rte_eth_macaddr_get(uint16_t port_id, struct rte_ether_addr *mac_addr);
> */
> int rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info);
>
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice.
> + *
> + * Retrieve the contextual information of an Ethernet device.
> + *
'rte_eth_dev_info_get()' is using "contextual information" but for this API can
we say 'configuration'?
> + * @param port_id
> + * The port identifier of the Ethernet device.
> + * @param dev_conf_info
> + * A pointer to a structure of type *rte_eth_dev* to be filled with
> + * the contextual information of the Ethernet device.
Just to make it more clear, what do you think to highlight that memory should be
allocated by the caller?
> + * @return
> + * - (0) if successful.
> + * - (-ENOTSUP) if support for dev_infos_get() does not exist for the device.
I think '-ENOTSUP' is not returned by the API.
> + * - (-ENODEV) if *port_id* invalid.
> + * - (-EINVAL) if bad parameter.
> + */
> +__rte_experimental
> +int rte_eth_dev_conf_info_get(uint16_t port_id,
> + struct rte_eth_conf *dev_conf_info);
> +
> /**
> * Retrieve the firmware version of a device.
> *
> diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
> index 44d30b05ae..40539f99f9 100644
> --- a/lib/ethdev/version.map
> +++ b/lib/ethdev/version.map
> @@ -249,6 +249,9 @@ EXPERIMENTAL {
> rte_mtr_meter_policy_delete;
> rte_mtr_meter_policy_update;
> rte_mtr_meter_policy_validate;
> +
> + # added in 21.11
> + rte_eth_dev_conf_info_get;
> };
>
> INTERNAL {
>
next prev parent reply other threads:[~2021-09-08 16:46 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 15:57 [dpdk-dev] [PATCH] app/testpmd: fix testpmd doesn't show RSS hash offload Jie Wang
2021-07-09 9:27 ` Andrew Rybchenko
2021-07-12 3:12 ` Li, Xiaoyun
[not found] ` <DM8PR11MB5639B19DACFB1B4F4E70ACA4D1149@DM8PR11MB5639.namprd11.prod.outlook.com>
2021-07-13 3:30 ` Li, Xiaoyun
2021-07-16 9:09 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-07-13 17:04 ` [dpdk-dev] [PATCH v2] " Jie Wang
2021-07-15 2:29 ` Li, Xiaoyun
2021-07-15 2:40 ` Li, Xiaoyun
2021-07-15 11:33 ` [dpdk-dev] [PATCH v3] " Jie Wang
2021-07-15 11:57 ` [dpdk-dev] [PATCH v4] " Jie Wang
2021-07-15 4:53 ` Li, Xiaoyun
2021-07-16 8:30 ` Li, Xiaoyun
2021-07-16 8:52 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
[not found] ` <DM8PR11MB5639C757A790F65CBFB647C2D1E19@DM8PR11MB5639.namprd11.prod.outlook.com>
2021-07-19 16:18 ` Ferruh Yigit
2021-07-22 11:03 ` Andrew Rybchenko
2021-08-09 8:53 ` Ferruh Yigit
2021-08-17 17:38 ` [dpdk-dev] [PATCH v5] " Jie Wang
2021-08-24 17:10 ` [dpdk-dev] [PATCH v6 0/2] testpmd shows incorrect rx_offload configuration Jie Wang
2021-08-24 17:10 ` [dpdk-dev] [PATCH v6 1/2] ethdev: add an API to get device configuration info Jie Wang
2021-08-24 17:10 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload Jie Wang
2021-08-26 7:09 ` [dpdk-dev] [PATCH v7 0/2] testpmd shows incorrect rx_offload configuration Jie Wang
2021-08-26 7:09 ` [dpdk-dev] [PATCH v7 1/2] ethdev: add an API to get device configuration info Jie Wang
2021-08-26 7:09 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload Jie Wang
2021-08-27 7:36 ` Li, Xiaoyun
2021-08-27 8:17 ` [dpdk-dev] [PATCH v8 0/2] testpmd shows incorrect rx_offload configuration Jie Wang
2021-08-27 8:17 ` [dpdk-dev] [PATCH v8 1/2] ethdev: add an API to get device configuration info Jie Wang
2021-09-08 16:46 ` Ferruh Yigit [this message]
2021-08-27 8:17 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload Jie Wang
2021-08-30 5:57 ` Li, Xiaoyun
2021-09-08 16:50 ` Ferruh Yigit
2021-09-09 3:31 ` Li, Xiaoyun
2021-09-17 10:20 ` Ferruh Yigit
2021-09-18 2:18 ` Li, Xiaoyun
2021-09-20 9:45 ` Ferruh Yigit
2021-09-20 9:48 ` Ferruh Yigit
2021-09-22 2:52 ` Wang, Jie1X
2021-09-26 9:20 ` [dpdk-dev] [PATCH v9 0/3] testpmd shows incorrect rx_offload configuration Jie Wang
2021-09-26 9:20 ` [dpdk-dev] [PATCH v9 1/3] ethdev: add an API to get device configuration info Jie Wang
2021-09-27 6:19 ` Thomas Monjalon
2021-09-27 7:21 ` Wang, Jie1X
2021-09-27 7:56 ` Thomas Monjalon
2021-10-04 11:20 ` Ferruh Yigit
2021-10-04 11:25 ` Thomas Monjalon
2021-10-04 11:22 ` Ferruh Yigit
2021-10-04 11:26 ` Thomas Monjalon
2021-10-04 11:35 ` Ferruh Yigit
2021-09-26 9:20 ` [dpdk-dev] [PATCH v9 2/3] doc: update release notes for new API Jie Wang
2021-10-04 11:22 ` Ferruh Yigit
2021-10-04 11:26 ` Thomas Monjalon
2021-09-26 9:20 ` [dpdk-dev] [PATCH v9 3/3] app/testpmd: fix testpmd doesn't show RSS hash offload Jie Wang
2021-10-08 3:41 ` [dpdk-dev] [PATCH v10 0/2] testpmd shows incorrect rx_offload configuration Jie Wang
2021-10-08 3:41 ` [dpdk-dev] [PATCH v10 1/2] ethdev: add an API to get device configuration info Jie Wang
2021-10-08 12:10 ` Ferruh Yigit
2021-10-08 3:41 ` [dpdk-dev] [PATCH v10 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload Jie Wang
2021-10-08 12:12 ` Ferruh Yigit
2021-10-11 18:01 ` [dpdk-dev] [PATCH v11 0/2] testpmd shows incorrect rx_offload configuration Jie Wang
2021-10-11 18:01 ` [dpdk-dev] [PATCH v11 1/2] ethdev: add an API to get device configuration Jie Wang
2021-10-11 10:08 ` Somnath Kotur
2021-10-11 12:21 ` Andrew Rybchenko
2021-10-11 18:01 ` [dpdk-dev] [PATCH v11 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload Jie Wang
2021-10-12 2:54 ` [dpdk-dev] [PATCH v12 0/2] testpmd shows incorrect rx_offload configuration Jie Wang
2021-10-12 2:54 ` [dpdk-dev] [PATCH v12 1/2] ethdev: add an API to get device configuration Jie Wang
2021-10-12 5:50 ` Andrew Rybchenko
2021-10-12 2:54 ` [dpdk-dev] [PATCH v12 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload Jie Wang
2021-10-12 14:37 ` Ferruh Yigit
2021-10-13 2:42 ` Wang, Jie1X
2021-10-13 8:50 ` Ferruh Yigit
2021-10-13 10:14 ` Ferruh Yigit
2021-10-12 14:35 ` [dpdk-dev] [PATCH v12 0/2] testpmd shows incorrect rx_offload configuration Ferruh Yigit
2021-10-14 10:31 ` [dpdk-dev] [PATCH v13 " Jie Wang
2021-10-14 10:31 ` [dpdk-dev] [PATCH v13 1/2] ethdev: add an API to get device configuration Jie Wang
2021-10-14 10:31 ` [dpdk-dev] [PATCH v13 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload Jie Wang
2021-10-14 12:56 ` [dpdk-dev] [PATCH v13 0/2] testpmd shows incorrect rx_offload configuration Ferruh Yigit
2021-10-15 10:43 ` Ferruh Yigit
2021-10-15 11:29 ` Ferruh Yigit
2021-08-24 18:19 ` [dpdk-dev] [PATCH v6 " Jie Wang
2021-08-24 18:19 ` [dpdk-dev] [PATCH v6 1/2] ethdev: add an API to get device configuration info Jie Wang
2021-08-25 20:07 ` Ferruh Yigit
2021-08-26 6:00 ` Ajit Khaparde
2021-08-24 18:19 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload Jie Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19ad2d4c-1d66-5a65-ad3e-e366bb461a16@intel.com \
--to=ferruh.yigit@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=jie1x.wang@intel.com \
--cc=thomas@monjalon.net \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).