From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 6892D2B98
 for <dev@dpdk.org>; Tue, 11 Oct 2016 14:31:05 +0200 (CEST)
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
 (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id A9CAE3D957;
 Tue, 11 Oct 2016 12:31:04 +0000 (UTC)
Received: from [10.36.4.73] (vpn1-4-73.ams2.redhat.com [10.36.4.73])
 by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u9BCUx6M025764
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Tue, 11 Oct 2016 08:31:01 -0400
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org,
 yuanhan.liu@linux.intel.com
References: <1469088510-7552-1-git-send-email-olivier.matz@6wind.com>
 <1475485223-30566-1-git-send-email-olivier.matz@6wind.com>
 <1475485223-30566-2-git-send-email-olivier.matz@6wind.com>
Cc: konstantin.ananyev@intel.com, sugesh.chandran@intel.com,
 bruce.richardson@intel.com, jianfeng.tan@intel.com,
 helin.zhang@intel.com, adrien.mazarguil@6wind.com,
 stephen@networkplumber.org, dprovan@bivio.net, xiao.w.wang@intel.com
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <19b2b7af-69af-24e6-8a81-d4557d6fa413@redhat.com>
Date: Tue, 11 Oct 2016 14:30:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1475485223-30566-2-git-send-email-olivier.matz@6wind.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.30]); Tue, 11 Oct 2016 12:31:04 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v2 01/12] virtio: move device initialization
 in a function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2016 12:31:05 -0000

Hi Olivier,

On 10/03/2016 11:00 AM, Olivier Matz wrote:
> Move all code related to device initialization in a new function
> virtio_init_device().
>
> This commit brings no functional change, it prepares the next commits
> that will add the offload support. For that, it will be needed to
> reinitialize the device from ethdev->configure(), using this new
> function.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  drivers/net/virtio/virtio_ethdev.c | 99 ++++++++++++++++++++++----------------
>  1 file changed, 58 insertions(+), 41 deletions(-)

Makes sense, feel free to add my:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime