From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 024BAA04B5; Thu, 29 Oct 2020 11:16:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C4D0C912; Thu, 29 Oct 2020 11:16:22 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id E3420C910 for ; Thu, 29 Oct 2020 11:16:20 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id n18so2106626wrs.5 for ; Thu, 29 Oct 2020 03:16:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=2S/JLuB91hAd5lTxXyfPX004XCm26cBbTh7/GotyjD0=; b=T0L7nueJG0yQMKMmhnp8K9FLGZUapAk+b6/SIhloc+56V5o/kPWQPqUxiVhFw+S/2X bmiMYdyP+d0ZraGzhqZ/SPzB8u7XBPMHsluoHN51Ho9uwmNLt4Ha7I+g/4k14YNNcHqS hbb/uuBk0KSCwskxEwLLnn0QQvXd+I6WCQjt7WQBopt7cZL335oo0oSdn13snA58tJKW l59vM8oONyUgM5v/+viV5YggUrV6Oz3DHOzNI8yROEODSoV/pqKhHLQzlnYDTRQQNYhW iZAagscIfExGUHtirGbUHrmNmWw9uvg9JdECWVdlI3c73ia/Pd4uFLUl/Co0gbXDZB9T eNuw== X-Gm-Message-State: AOAM532tOsb5aJ3wFriVfw2m+EcINyoZ7UmkvYpetFYJY/ESi6rzu9h6 8fs6+pyscsiB44D/lOtZUUw= X-Google-Smtp-Source: ABdhPJyWZTbMVexlVDJFkTAODX46gY+R5TSEUwOgGaZOYvcTakIAwmfRFe+REVtoi07bOJCuf65Fkw== X-Received: by 2002:a5d:6681:: with SMTP id l1mr4654844wru.356.1603966579688; Thu, 29 Oct 2020 03:16:19 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id u9sm4299270wrp.65.2020.10.29.03.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 03:16:18 -0700 (PDT) Message-ID: <19bcf4dda0f0908e1ebda104867441cf38870dda.camel@debian.org> From: Luca Boccassi To: Hariprasad Govindharajan , dev@dpdk.org Cc: ferruh.yigit@intel.com, anatoly.burakov@intel.com Date: Thu, 29 Oct 2020 10:16:18 +0000 In-Reply-To: <1602150008-16177-1-git-send-email-hariprasad.govindharajan@intel.com> References: <1601909255-26251-1-git-send-email-hariprasad.govindharajan@intel.com> <1602150008-16177-1-git-send-email-hariprasad.govindharajan@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2020-10-08 at 10:40 +0100, Hariprasad Govindharajan wrote: > With DPDK 20.11 release, the igb_uio module is no more part of DPDK. > There are use cases where this module is required, for example while > testing the virtual ports in OvS, the virtual ports are bound to > igb_uio module inside a VM. So, this patch provides a Makefile > which can be used to build this module and use as needed. >=20 > Before building this module, the user is expected to build the > DPDK using meson build system and make sure that the required > libraries are installed in the path /usr/local >=20 > Signed-off-by: Hariprasad Govindharajan > --- > This patch will be part of dpdk-kmods repo > https://git.dpdk.org/dpdk-kmods/ > --- > v4: > Corrected the indentation > v3: > Edited the commit message and corrected the mistakes in the variable > definition > v2: > Added more information to the commit message > --- > linux/igb_uio/Makefile | 8 ++++++++ > 1 file changed, 8 insertions(+) > create mode 100644 linux/igb_uio/Makefile >=20 > diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile > new file mode 100644 > index 0000000..45dbe42 > --- /dev/null > +++ b/linux/igb_uio/Makefile > @@ -0,0 +1,8 @@ > +DPDK_HEADERS ?=3D /usr/local/include Please don't hard-code values that are provided programmatically. Use pkgconfing instead: $(shell pkg-config --variable=3Dincludedir libdpdk) > +RTE_KERNELDIR ?=3D /lib/modules/`uname -r`/build This is not a dpdk specific location so it doesn't need an RTE prefix. While there isn't a unique way of calling this, the most common name I see being used is KSRC. > + > +all: > + make EXTRA_CFLAGS=3D"-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR)/ M=3D$(PWD= ) > + > +clean: > + make -C $(RTE_KERNELDIR)/ M=3D$(PWD) clean --=20 Kind regards, Luca Boccassi