From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2199CA318B
	for <public@inbox.dpdk.org>; Fri, 18 Oct 2019 10:23:29 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 583D61C0C1;
	Fri, 18 Oct 2019 10:23:27 +0200 (CEST)
Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35])
 by dpdk.org (Postfix) with ESMTP id 257D51C02F
 for <dev@dpdk.org>; Fri, 18 Oct 2019 10:23:25 +0200 (CEST)
Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58])
 by Forcepoint Email with ESMTP id C45E082BD2CD63FAFBD1;
 Fri, 18 Oct 2019 16:23:20 +0800 (CST)
Received: from [127.0.0.1] (10.57.115.182) by DGGEMS402-HUB.china.huawei.com
 (10.3.19.202) with Microsoft SMTP Server id 14.3.439.0; Fri, 18 Oct 2019
 16:23:18 +0800
To: Ferruh Yigit <ferruh.yigit@intel.com>, "Wei Hu (Xavier)"
 <xavier.huwei@tom.com>, <dev@dpdk.org>
References: <20191009141653.39364-1-xavier.huwei@tom.com>
 <20191009141653.39364-2-xavier.huwei@tom.com>
 <31868759-1900-2aad-4e38-0ae8fe52647a@intel.com>
From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
Message-ID: <19c1373f-5d29-b89e-08c7-6884bac83fd5@huawei.com>
Date: Fri, 18 Oct 2019 16:23:17 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <31868759-1900-2aad-4e38-0ae8fe52647a@intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.57.115.182]
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH 1/4] net/hns3: modify the statistics for
 sending and receiving messages
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Ferruh Yigit


On 2019/10/15 16:45, Ferruh Yigit wrote:
> On 10/9/2019 3:16 PM, Wei Hu (Xavier) wrote:
>> From: Hao Chen <chenhao164@huawei.com>
>>
>> In receiving direction, for FCS error messages, drivers no longer
>> record them in rte_eth_stats.ipackets statistics.
> If this patch is fixing statistics better to convert commit log into a fix patch
> with Fixes tags etc. This helps for your patches has been backported to LTS.
> Same for other patches in the set.
>
>> In sending direction, for messages of illegal length, too long or
>> equals 0, drivers will not notify the network card hardware to
>> send them, will not continue to send the remaining message in burst,
>> and will not record them in rte_eth_stats.opackets statistics.
>>
>> Signed-off-by: Hao Chen <chenhao164@huawei.com>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> <...>
>
>> @@ -979,6 +976,7 @@ hns3_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
>>  		first_seg->pkt_len = pkt_len;
>>  		first_seg->port = rxq->port_id;
>>  		first_seg->hash.rss = rte_le_to_cpu_32(rxdp->rx.rss_hash);
>> +		first_seg->ol_flags |= PKT_RX_RSS_HASH;
> This is unrelated change for this patch, can you please extract into its own patch?
>
  We will fix them and send patch V2.
  Thanks for your comment.

  Regards
Xavier