From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACEB9A0552; Thu, 20 Oct 2022 13:12:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A402B42D3A; Thu, 20 Oct 2022 13:12:41 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2058.outbound.protection.outlook.com [40.107.96.58]) by mails.dpdk.org (Postfix) with ESMTP id 351B742C80 for ; Thu, 20 Oct 2022 13:12:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=etPVv6l4fbgXiZ0XzFst6xM2MFfqhcM8VHvtNmij7gdm9MBpi5APWzZKczG6aWqOARuhWfEzG3XuqbljftjlOx6s6bWRB1evfSgP9p1uTP5Q6rK4p7GlmxZK5V+6lO6RYV49hlUNS7bX5sOlC0da+nzbGmB7SagGrk5V8a/TN4NsgJGhvw5vgWkmijGWHZz9O6eqIOdgnQzKk77As6FpKPKou3LtxD7F1RrLeQhthF4bqLG/mJQ0AR03Wdq93KL+lL5sB43mO9XRc94NEgyftH4qXFeBC7oL6KDoeABC/GW/zy9MvkN3OezVBWu7A2/2zH790hRFxWQKWvE06ivxgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AETCIb2GkDt9ySMoXx6EKTJzyWxVj/B+aFKpDEsrkis=; b=nsJC+WOQIM4sTZMreBpdsBaElcurmmKQESmgLdatYKhp5JyxbV07W3JTTIJ9favLNgEgOSJD7552rI4Pe/Y8Q6yMdKlleWY8mawp3VKpKl5qCP98TLTQtlazjwBG2Z4tKIAF6Wuh7RkjnlCeLhxkKJsLm4kblTCbf15x0btRL2nW4P1/W28w9KPdsouOoO+9nSky19tEGAa6Rw703QCCsh/852/QmFKFJQaqlBfO8s6w9+hBfqFnzwrAnTxDA/tdhF1SS/gOorpMhVxK2kvSYCGostXkzryWj7cZlHc5Dtz+BeciDmM9zZiVMxRyBxInUxSzQTxf7ougelzOf6gCFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AETCIb2GkDt9ySMoXx6EKTJzyWxVj/B+aFKpDEsrkis=; b=DtIfK2yjuxrxHusqgHbojMFeySZJ+XQgT+1meqYZyRE8OgjLYu1VkTQ3cD084jF4cjFt49L9X3BhiCgnvzAcHNRYufcseIhUiZM//7crpIAZs/PtxsVG4Vn7cZBFC4+2i6QnZIZAEskXCaF4v4c7ZvW8aaRCVr5dF1I/lsDGYc4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by CH2PR12MB4040.namprd12.prod.outlook.com (2603:10b6:610:ac::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Thu, 20 Oct 2022 11:12:38 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Thu, 20 Oct 2022 11:12:38 +0000 Message-ID: <19e889dc-701b-c3fc-3194-a792eccd4f7c@amd.com> Date: Thu, 20 Oct 2022 12:12:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v5 13/25] net/nfp: support SRC MAC flow action Content-Language: en-US To: Chaoyong He , Andrew Rybchenko , Ori Kam Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, dev@dpdk.org References: <1666092434-10357-1-git-send-email-chaoyong.he@corigine.com> <1666232391-29152-1-git-send-email-chaoyong.he@corigine.com> <1666232391-29152-14-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1666232391-29152-14-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0329.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::29) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|CH2PR12MB4040:EE_ X-MS-Office365-Filtering-Correlation-Id: 772f84ec-1fc4-410d-eed3-08dab28bff66 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2diOjEKLA/hOq235im/+ktSO476/ofXrXe4upFjn9mcsq//pr1TZJ+OCPlpy123CV+AgA3S82qafd3zRHYcqEO8fw8e521Vx7sVmv3MlIP5bJoMzcbj4fZHh3RJ4SFQcewi1WdXBaYE6yFYSD9YMkXxxJ2vux2dBf9J66sSGngeLvzRroooTvIzWxYjD/BcLPJdvayw98idDRnBMjoD4Ph785v+zwBikEF1EEoJidHDsNhwxWQkqfo45qsais1GsGIMCMOiTSaVeBMV9hKa1l+64DPdPQ60myJXnqVFXw72xrpchrGUF50P+h8Yw5R7GgAR6VA4Deo5BDcrHtYrP77KEdIBWJkvUmbD+kn26SsXh4x1+M3h5ZdujtGW7D4bC6Lr2so8U8+ZJTgNJ3jnluRL0HwB7V1aCEBLymfzQsX94zywMh+YwxP4AK0VMYDLA3+dGGv3vVfdsvL8UQZIpug8hhJ825HCGje2TZ7HDBjbndt8h5IoaA5u7ORj/ASLi/o8H1DRL1l0XWuN1RP/G9NzvbwJl1N8V7f/i977uVFoDGMhVjKTDWR1oimTbGKOap/ipFTWOkccXjLab2cacIA9/ibeCACuFml0RMhDeQDyRQ9mqRgE//gubWy0JQo18yaxz1J2jjnzbFt3OKypgd5aYclY6mZCd7q4kJ/0+VgPk+CnRTqiabt0GtSnuAk+PwfJmZXkj5gcagMirM2Q32Bznz4fQPM0b9BiAIZHdpN7ThsyazDIjIG6z0GdPkKkNBJKUi0E22kjavVIZVoRQbkvsUve/yVrflgmGtQHXtSg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(366004)(451199015)(31686004)(2906002)(31696002)(41300700001)(66556008)(8936002)(86362001)(5660300002)(66476007)(44832011)(4744005)(53546011)(6506007)(8676002)(6512007)(4326008)(26005)(316002)(110136005)(66946007)(6666004)(38100700002)(36756003)(478600001)(6486002)(2616005)(186003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGxEK1ZQYS9OUUwzYkhsK3hNSUtMcVdvTm1CZ25xaGh2MmI2M2h4dlBEUGdz?= =?utf-8?B?ZHNEVk5yc3Zvd3FsSDJEVTZVVGxkdnF6UHJRdzBFVFNvUmxKRXM4NlVESnVN?= =?utf-8?B?VTFUWFp0a3c2dloxNDRqNDRtdDR2ZUpodDZRZ2k4bnVqTGZvZ1B3bzVvWXhR?= =?utf-8?B?YTNVYzhOWkFmTGRZVlZaRDFIc0VoY0dzRzFMTklPTk5aZ09jYkI5STEvdTc5?= =?utf-8?B?WTJiU3hyMWErdTFPM3UvQUZXT3NuK0NuVk5qRW1Sa05DemZXM2NmSlNKbVJq?= =?utf-8?B?WDhXWTl4VlR2YTJralN5RU94L01EODRBb3ZQYkt3WWNOYUtVVUEyK2lBNi8z?= =?utf-8?B?ck95a2c3ZnhYK0QrY2V5Vm5oWmg5cUxyUElsYkxYdm5GWk5OT1NQTWU0THFS?= =?utf-8?B?VmVPaFBZYnhXSjdCd1hSaWhxaHJtWGtta2UvMTYzRWY1MmFuN2w3R1g0YW5i?= =?utf-8?B?N3JoSVNSWEJ4YlJtekcrc2RIbk0wK0VZTk9yS25IVGxsK0JzbW02L1pnZVdz?= =?utf-8?B?Z01XSjdUOURhUHV2bURJUktLbmlBK3REWUFlVkZ2THZLNFptdHp1VUY1dVR6?= =?utf-8?B?RDhpMlBUMENzYk81QkQxMW04U1JrQkp0RCtsNW5Bbjc3ZDVlNDE2elhELzEz?= =?utf-8?B?RkV0V0o3T0o0TGsydGdFK2kraUN5NnI4U0V4K1FNWTlWNldCaUh0VmJlZ2FK?= =?utf-8?B?T1FjZVBUNTk2M3d4QVlWZDJNTEZhd1Z5Y1VxS0dsK3JCZGxHV2YwcVNBaG9a?= =?utf-8?B?amZBREZ3Y043alVsSENrL2R5UnIwK09ob051U2JDZXVNTUMreWxSNmF5UDJT?= =?utf-8?B?T2h5a0pIV0ZsdXlwUXBzYi90dE1ZZWczQlJBbmZ1WVlySytDa3BzVGtZUTl0?= =?utf-8?B?dHBQbENZcVNZTTRJWXhhZGNlRDdNZENQWnNoM0I0S3JuYUYreitBR1BRNzdB?= =?utf-8?B?RTNHN1p6eklzZW5XcXZQdDlpOFhvcEFXTjZ5UDFKY2lKNjhvOFBaa0ZlOTBX?= =?utf-8?B?dmVFRGYrTW9UVStiTlNnbFh6RlUwZDNIQjJLSzhLcnJ5d3ZjeUl0ZFU0RERq?= =?utf-8?B?NWlQWlAxa1dOUm1xVkppSUwzWmVGTW9XcmdPcnN0QlBRZWJ2S3BHdDNjRkVl?= =?utf-8?B?bm1HVlpHMVlwOG92ZlR4ZUJqdDJnVTBLeGZnT0xYZy9VRlYyUGo1WnBFMER4?= =?utf-8?B?VlU2Q0J1N05IbnRRa2hMNzBmZ3lqSHlDK2pyWDhYQU1QdFE0ZW9rL0djQjE2?= =?utf-8?B?WmZFN3U1TTZsQUpmMUhGK3NLT1ZPak5vQXRiUFZJWUFuMStrelJucVVNS2dE?= =?utf-8?B?QWN6cDNyTk9FMzZ5L0tWbk5TWHE2VTJRUEx5dWpuYjc2SS8rckZGWWhpR3Iz?= =?utf-8?B?YytSWWlSMXdUbHk3UXRWTEhRMkgrT2FrWHNhUWNnSUNUd1VwZGUrTFBsNXNy?= =?utf-8?B?V1N6TWF2Z0Z2S2Q0Mk1qUjY1RW5vR1EydHJRYVM2UWVjTWVvTU9rZHZtdHlM?= =?utf-8?B?cHJHaVdBRHhTVTRCaUpBbkEvZVBvSGZwa0UrS29qR0VBbEp1bUFIWFdRZ09B?= =?utf-8?B?Nzg0MzQ2S2FoMHhvYlV2Ui9nZFdSc1k4OUMwdHAwZVQ0UmVnR2hYYzZLRStI?= =?utf-8?B?Nk5KV1RUWEJpRFU1UHd5UmhlVmh6bHRHNHBaMmxmbjdRMTFKTXUrWHpkYjFM?= =?utf-8?B?Y0JsMEJCS25pcHcrSkhkK3ZRa3VleU9nVDJtb0h0cWxSV2FsSEtuSm5KYU1w?= =?utf-8?B?ZDVzMlFpWnBkTm9GbG1iZm5vaGJtT2Jpa1ZOMWpVQWJsd3J6Q3JFUHhtdEMz?= =?utf-8?B?R1VKRXNiV1BGdmxLMVJkbU5iOFlaVWJ6a3JUYldLaVBhVnkwbVVkT09mcUR1?= =?utf-8?B?ajNsbWlDL3NBdG4wdGNQcklCVDVRRmZ5eldQRTJMRGF4eHY3NDlRVXhqTUYy?= =?utf-8?B?MWF1SU4wdzR5dmxBZDJNamVRbmtaZGVRMjA0UW15amIrZVZnaWtOZnhpSTh1?= =?utf-8?B?UkZqTjVuYkVKbFRZZXdzMWFGVitCT2hqMnFGRzFpODJTRmkwa2FWR3QrN1J2?= =?utf-8?B?R1p0aFhWUXRNbG11cjJhdjZ5eW0yeWpOek1ZNldlWGVFWlZsb3VhWHdoK3Qv?= =?utf-8?Q?SdRGLej47/zora3d3RlJrhbyf?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 772f84ec-1fc4-410d-eed3-08dab28bff66 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2022 11:12:38.3980 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FmH5tf8G60ufVQwQw/njNfiZKpKO/hFQGxPYOShJJ5R+ZLUCpr5usiKzcRmYiAmy X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4040 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/20/2022 3:19 AM, Chaoyong He wrote: > Add the corresponding data structure and logics, to support > the offload of set source MAC action. > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund <...> > + case RTE_FLOW_ACTION_TYPE_SET_MAC_SRC: > + PMD_DRV_LOG(DEBUG, "Process RTE_FLOW_ACTION_TYPE_SET_MAC_SRC"); > + nfp_flow_action_set_mac(position, action, true, mac_set_flag); > + if (!mac_set_flag) { > + position += sizeof(struct nfp_fl_act_set_eth); > + mac_set_flag = true; > + } Hi Andrew, Ori, I can see 'RTE_FLOW_ACTION_TYPE_SET_MAC_SRC' and many other marked as legacy and reference to 'RTE_FLOW_ACTION_TYPE_MODIFY_FIELD'. What is the expectation from PMD developers for this? User still can provide these legacy actions, right? So should PMD implement both legacy and new ones?