From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 667ADA04B1; Wed, 4 Nov 2020 23:25:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 812872C2E; Wed, 4 Nov 2020 23:25:18 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 0BF8B2C2A for ; Wed, 4 Nov 2020 23:25:16 +0100 (CET) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A4M2obB103199; Wed, 4 Nov 2020 17:25:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Ul2pnaSx4/C6VfMfSa5l6iw7fsTTDzsWDd8TlQP9RCw=; b=AufBMb3qnd7B3GU3cOxnBR4pJheYjTq7Kocr2nqsuNUM3v+bRPvXYLU0ZeyBLd93xlnZ 9xBmRjFDry9tIqt52DwQoCVoDJtgP3rYN8IR1NANOgrak82CvyhFSjXbGl9dZcWDTV0P gF27xCzHgqCcutp+y+6SidL73Kj++6/LwvmwfPpQldnh8JqkhUAQW2ZUPxs71vxbTea9 ACHgs1c3yxudkAUp7rrBgZEL2k9M4t4d8bqAOQ9cZ8M5HIYURYSZrGqcjV+7G51KffEr FB52ZJLigP6h9u1UoGGqENVF6DB+TeVv2hxZpIutJiBquKkj8VsQeel36n1TEE74xAzL gQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 34m47x17xb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Nov 2020 17:25:15 -0500 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0A4M3lq2107568; Wed, 4 Nov 2020 17:25:14 -0500 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 34m47x17x1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Nov 2020 17:25:14 -0500 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0A4MNlZU010587; Wed, 4 Nov 2020 22:25:13 GMT Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by ppma01dal.us.ibm.com with ESMTP id 34h0s7m4sy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Nov 2020 22:25:13 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0A4MPDHn10158840 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Nov 2020 22:25:13 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DF626124052; Wed, 4 Nov 2020 22:25:12 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6FF3512405B; Wed, 4 Nov 2020 22:25:12 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.163.93.107]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 4 Nov 2020 22:25:12 +0000 (GMT) To: Thomas Monjalon Cc: dev@dpdk.org, anatoly.burakov@intel.com, david.marchand@redhat.com References: <20201015172305.105717-1-drc@linux.vnet.ibm.com> <4042743.04XgZqB5lT@thomas> <45613e0e-7824-d976-9dd0-ffc74513dc88@linux.vnet.ibm.com> <1866859.44BVCP9YqW@thomas> From: David Christensen Message-ID: <19f7c0b2-9179-5587-c0c8-e9f417cfc64f@linux.vnet.ibm.com> Date: Wed, 4 Nov 2020 14:25:11 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <1866859.44BVCP9YqW@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-04_15:2020-11-04, 2020-11-04 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 mlxscore=0 suspectscore=0 phishscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011040156 Subject: Re: [dpdk-dev] [PATCH v5 1/1] vfio: modify spapr iommu support to use static window sizing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/4/20 1:02 PM, Thomas Monjalon wrote: > 04/11/2020 22:00, David Christensen: >> >> On 11/4/20 11:43 AM, Thomas Monjalon wrote: >>>> Signed-off-by: David Christensen >>>> Acked-by: Anatoly Burakov >>>> --- >>>> -#ifdef VFIO_IOMMU_SPAPR_INFO_DDW >>>> - /* try possible page_shift and levels for workaround */ >>>> + /* if at first we don't succeed, try more levels */ >>>> uint32_t levels; >>>> >>>> - for (levels = create->levels + 1; >>>> + for (levels = create.levels + 1; >>>> ret && levels <= info.ddw.levels; levels++) { >>> >>> There is a compilation failure with ppc64le-power8-linux-gcc: >>> error: ‘struct vfio_iommu_spapr_tce_info’ has no member named ‘ddw’ >> >> How did you find that error? It builds locally for me on a POWER system >> with Meson/gcc and there were no build failures on Travis >> (https://travis-ci.com/github/drchristensen/dpdk/builds/198047029) when >> I checked it against AMD64/ARM systems. The code is PPC specific but it >> will build on all architectures (there are no IFDEFs around it). > > Remember, I cross-build with test-meson-builds.sh > Is it an issue of my toolchain? > What distro/gcc version are you using? I'll try it locally on an x86. Dave