From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 364F8A046B; Thu, 9 Jan 2020 11:42:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB1F91DC10; Thu, 9 Jan 2020 11:42:38 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 29A881DC0B for ; Thu, 9 Jan 2020 11:42:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578566556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4vZLIvF4zDzsOMJBJ+23RScYXTBeNhxRA+zWxdXYJkE=; b=Cd83kmBlTondgHbkBzZ7e5EFwOfRC3a3VvbEdSWky8+aVjzdI9LEC6EiWEw2gR1e54PYar RT/9OanOIep1bsOX5z8POnlW1cNg4TxC/N2ot9gMog28925+IvtB8zP+oJNZyxR9g82miQ 5l+meaSUn7BqtInm3BDqv58skvNI4qc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-93-PXok0Az1OPaH2NQp8Fn4Cw-1; Thu, 09 Jan 2020 05:42:33 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7EE8A10054E3; Thu, 9 Jan 2020 10:42:31 +0000 (UTC) Received: from [10.36.112.41] (ovpn-112-41.ams2.redhat.com [10.36.112.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B12D60BE0; Thu, 9 Jan 2020 10:42:28 +0000 (UTC) To: "Xu, Rosen" , Thomas Monjalon Cc: Matan Azrad , "Bie, Tiwei" , "Wang, Zhihong" , "Wang, Xiao W" , "Yigit, Ferruh" , "dev@dpdk.org" , "Pei, Andy" References: <1577287161-10321-1-git-send-email-matan@mellanox.com> <2962572.5fSG56mABF@xps> <0E78D399C70DA940A335608C6ED296D73AC7E548@SHSMSX104.ccr.corp.intel.com> <1669723.3VsfAaAtOV@xps> <269e1b71-89de-94a2-58db-221f78ef3955@redhat.com> <0E78D399C70DA940A335608C6ED296D73AC7FA9C@SHSMSX104.ccr.corp.intel.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <19ff3c83-0045-a039-b55a-a251e163a865@redhat.com> Date: Thu, 9 Jan 2020 11:42:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <0E78D399C70DA940A335608C6ED296D73AC7FA9C@SHSMSX104.ccr.corp.intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: PXok0Az1OPaH2NQp8Fn4Cw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/9/20 10:49 AM, Xu, Rosen wrote: > > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Thursday, January 09, 2020 17:24 >> To: Thomas Monjalon ; Xu, Rosen >> >> Cc: Matan Azrad ; Bie, Tiwei ; >> Wang, Zhihong ; Wang, Xiao W >> ; Yigit, Ferruh ; >> dev@dpdk.org; Pei, Andy >> Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device >> drivers >> >> >> >> On 1/9/20 9:41 AM, Thomas Monjalon wrote: >>> 09/01/2020 03:27, Xu, Rosen: >>>> Hi, >>>> >>>> From: Thomas Monjalon >>>>> 08/01/2020 13:39, Xu, Rosen: >>>>>> From: Matan Azrad >>>>>>> From: Xu, Rosen >>>>>>>> Did you think about OVS DPDK? >>>>>>>> vDPA is a basic module for OVS, currently it will take some >>>>>>>> exception path packet processing for OVS, so it still needs to >>>>>>>> integrate >>>>> eth_dev. >>>>>>> >>>>>>> I don't understand your question. >>>>>>> >>>>>>> What do you mean by "integrate eth_dev"? >>>>>> >>>>>> My questions is in OVS DPDK scenario vDPA device implements eth_dev >>>>>> ops, so create a new class and move ifc code to this new class is not ok. >>>>> >>>>> 1/ I don't understand the relation with OVS. >>>>> >>>>> 2/ no, vDPA device implements vDPA ops. >>>>> If it implements ethdev ops, it is an ethdev device. >>>>> >>>>> Please show an example of what you claim. >>>> >>>> Answers of 1 and 2. >>>> >>>> In OVS DPDK, each network device(such as NIC, vHost etc) of DPDK >>>> needs to be implemented as rte_eth_dev and provides eth_dev_ops such >> as packet TX/RX for OVS. >>> >>> No, OVS is also using the vhost API for vhost port. >>> >>>> Take vHost(Virtio back end) for example, OVS startups vHost interface like >> this: >>>> ovs-vsctl add-port br0 vhost-user-1 -- set Interface vhost-user-1 >>>> type=dpdkvhostuser drivers/net/vhost implements vHost as rte_eth_dev >> and integrated in OVS. >>>> OVS can send/receive packets to/from VM with rte_eth_tx_burst() >>>> rte_eth_rx_burst() which call eth_dev_ops implementation of >> drivers/net/vhost. >>> >>> No, it is using rte_vhost_dequeue_burst() and >>> rte_vhost_enqueue_burst() which are not in ethdev. >>> >>>> vDPA is also Virtio back end and works like vHost, same as vHost, it >>>> will be implemented as rte_eth_dev and also be integrated into OVS. >>> >>> No, vDPA is not "implemented as rte_eth_dev". >>> >>>> So, it's not ok to move ifc code from drivers/net. >>> >>> drivers/net/ifc has no ethdev implementation at all. >>> >>> >>> Rosen, I'm sorry, these arguments look irrelevant, so I won't consider >>> them as blocking the integration of this patch. >>> >>> >> >> I agree with Thomas, the vDPA drivers do not implement the ethdev ops. > > For OVS hasn't integrated vDPA, it doesn't implement ethdev ops, but there are many > discussions in OVS community about vDPA, it seems vDPA will be supported in OVS in > the near feature. I agree with this statement, but if you look at Mellanox series being reviewed, it is defining a new type of port and not use the regular DPDK port type. >> And OVS does not use the Vhost PMD for the Vhost-user ports, but directly >> call the librte_vhost APIs. > > I'm afraid you are wrong, pls read these documents which introduce how to use vHost-user PMD in OVS: > http://docs.openvswitch.org/en/latest/topics/dpdk/vhost-user/ > http://docs.openvswitch.org/en/latest/topics/dpdk/pmd/ I can confirm that below command to add ports is not using Vhost PMD but directly the librte_vhost API: $ ovs-vsctl add-port br0 dpdkvhostclient0 \ -- set Interface dpdkvhostclient0 type=dpdkvhostuserclient \ options:vhost-server-path=/tmp/dpdkvhostclient0 Please check the OVS source code. It is possible to use the Vhost PMD as a regular DPDK port, but this is not with above command, and not the recommended way. >> Regards, >> Maxime >