From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 938568DA2 for ; Wed, 19 Aug 2015 14:53:49 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 19 Aug 2015 05:53:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,709,1432623600"; d="scan'208";a="787036467" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by orsmga002.jf.intel.com with ESMTP; 19 Aug 2015 05:53:48 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.183]) by IRSMSX106.ger.corp.intel.com ([169.254.8.112]) with mapi id 14.03.0224.002; Wed, 19 Aug 2015 13:53:46 +0100 From: "Tahhan, Maryam" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 4/9] ethdev: remove HW specific stats in stats structs Thread-Index: AQHQvv/RSl+g1qZfa0mP83r0NzTrfJ4QakUAgAMSz6A= Date: Wed, 19 Aug 2015 12:53:46 +0000 Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536A4E5720@IRSMSX109.ger.corp.intel.com> References: <1436965894-130019-1-git-send-email-maryam.tahhan@intel.com> <1436965894-130019-5-git-send-email-maryam.tahhan@intel.com> <55D1F57A.8090408@6wind.com> In-Reply-To: <55D1F57A.8090408@6wind.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 4/9] ethdev: remove HW specific stats in stats structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2015 12:53:50 -0000 > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Monday, August 17, 2015 3:54 PM > To: Tahhan, Maryam; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 4/9] ethdev: remove HW specific stats i= n > stats structs >=20 > Hi Maryam, >=20 > On 07/15/2015 03:11 PM, Maryam Tahhan wrote: > > Remove non generic stats in rte_stats_strings and mark the relevant > > fields in struct rte_eth_stats as deprecated. > > > > Signed-off-by: Maryam Tahhan > > --- > > doc/guides/rel_notes/abi.rst | 12 ++++++++++++ > > lib/librte_ether/rte_ethdev.c | 9 --------- > > lib/librte_ether/rte_ethdev.h | 30 ++++++++++++++++++++---------- > > 3 files changed, 32 insertions(+), 19 deletions(-) > > > > diff --git a/doc/guides/rel_notes/abi.rst > > b/doc/guides/rel_notes/abi.rst index 931e785..d5bf625 100644 > > --- a/doc/guides/rel_notes/abi.rst > > +++ b/doc/guides/rel_notes/abi.rst > > @@ -24,3 +24,15 @@ Deprecation Notices > > > > * The Macros RTE_HASH_BUCKET_ENTRIES_MAX and > RTE_HASH_KEY_LENGTH_MAX are > > deprecated and will be removed with version 2.2. > > + > > +* The following fields have been deprecated in rte_eth_stats: > > + * uint64_t imissed > > + * uint64_t ibadcrc > > + * uint64_t ibadlen > > + * uint64_t imcasts > > + * uint64_t fdirmatch > > + * uint64_t fdirmiss > > + * uint64_t tx_pause_xon > > + * uint64_t rx_pause_xon > > + * uint64_t tx_pause_xoff > > + * uint64_t rx_pause_xoff >=20 > Looking again at this patch, I'm wondering if "imissed" should be kept in= stead > of beeing deprecated. I think it could be useful to differentiate ierrors= from > imissed, and it's not a hw-specific statistic. What do you think? >=20 > One more comment: it seems these fields are marked as deprecated but they > are still used on other drivers (e1000, i40e, ...). >=20 > Regards, > Olivier >=20 Hi Olivier I can remove the deprecated status for imissed to leave the differentiation= between errors and missed packets. igb and i40e will be updated soon to reflect this. I marked them as depreca= ted to deter their use in the future. Older instances/use will need to be r= esolved. Regards Maryam