From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B6FB5234 for ; Fri, 23 Oct 2015 17:28:43 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 23 Oct 2015 08:28:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,186,1444719600"; d="scan'208";a="833929927" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga002.fm.intel.com with ESMTP; 23 Oct 2015 08:28:33 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.139]) by IRSMSX101.ger.corp.intel.com ([169.254.1.33]) with mapi id 14.03.0248.002; Fri, 23 Oct 2015 16:28:32 +0100 From: "Tahhan, Maryam" To: "Van Haaren, Harry" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 03/11] ethdev: update xstats_get() strings and Q handling Thread-Index: AQHRDOFLjkFiDz1vqU+TPHbnVtAUGJ55JUfQgAAPqTA= Date: Fri, 23 Oct 2015 15:28:31 +0000 Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536A5D959D@IRSMSX109.ger.corp.intel.com> References: <1443606022-13581-2-git-send-email-harry.van.haaren@intel.com> <1445528914-27636-1-git-send-email-harry.van.haaren@intel.com> <1445528914-27636-4-git-send-email-harry.van.haaren@intel.com> <1A27633A6DA49C4A92FCD5D4312DBF536A5D93C0@IRSMSX109.ger.corp.intel.com> In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536A5D93C0@IRSMSX109.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 03/11] ethdev: update xstats_get() strings and Q handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2015 15:28:44 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tahhan, Maryam > Sent: Friday, October 23, 2015 3:35 PM > To: Van Haaren, Harry ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 03/11] ethdev: update xstats_get() stri= ngs > and Q handling >=20 > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren > > Sent: Thursday, October 22, 2015 4:48 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v3 03/11] ethdev: update xstats_get() > > strings and Q handling > > > > Update the strings used for presenting stats to adhere to the scheme > > previously presented. Updated xstats_get() function to handle Q > > information only if xstats() is not implemented in the PMD, providing > > the PMD with the needed flexibility to expose its extended Q stats. > > > > Signed-off-by: Harry van Haaren > > --- > > lib/librte_ether/rte_ethdev.c | 38 > > +++++++++++++++++++++++--------------- > > 1 file changed, 23 insertions(+), 15 deletions(-) > > > > diff --git a/lib/librte_ether/rte_ethdev.c > > b/lib/librte_ether/rte_ethdev.c index f593f6e..07f0c26 100644 > > --- a/lib/librte_ether/rte_ethdev.c > > +++ b/lib/librte_ether/rte_ethdev.c > > @@ -137,27 +137,30 @@ struct rte_eth_xstats_name_off { }; > > > > static const struct rte_eth_xstats_name_off rte_stats_strings[] =3D { > > - {"rx_packets", offsetof(struct rte_eth_stats, ipackets)}, > > - {"tx_packets", offsetof(struct rte_eth_stats, opackets)}, > > - {"rx_bytes", offsetof(struct rte_eth_stats, ibytes)}, > > - {"tx_bytes", offsetof(struct rte_eth_stats, obytes)}, > > - {"tx_errors", offsetof(struct rte_eth_stats, oerrors)}, > > + {"rx_good_packets", offsetof(struct rte_eth_stats, ipackets)}, > > + {"tx_good_packets", offsetof(struct rte_eth_stats, opackets)}, > > + {"rx_good_bytes", offsetof(struct rte_eth_stats, ibytes)}, > > + {"tx_good_bytes", offsetof(struct rte_eth_stats, obytes)}, >=20 > Hi Harry > If there are any apps today scraping the existing stats this will cause a= n issue. > I think the "good" description breaks the meaning of the various stats de= fined > in the header. For example rx_packets is Total number of successfully > received packets rather than the "good" packets. >=20 > BR > Maryam > > {"rx_errors", offsetof(struct rte_eth_stats, ierrors)}, My bad, was quoting the wrong stats register... I'm happy with this change