From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 5BFA58EA1 for ; Fri, 22 Jan 2016 15:48:53 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 22 Jan 2016 06:48:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,331,1449561600"; d="scan'208";a="639524524" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by FMSMGA003.fm.intel.com with ESMTP; 22 Jan 2016 06:48:50 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.197]) by IRSMSX108.ger.corp.intel.com ([169.254.11.102]) with mapi id 14.03.0248.002; Fri, 22 Jan 2016 14:48:49 +0000 From: "Tahhan, Maryam" To: Thomas Monjalon , "David Harton (dharton)" Thread-Topic: [dpdk-dev] Future Direction for rte_eth_stats_get() Thread-Index: AdFToifrMKxGpVsMS/qKv8msWpPa2wABEBgwAFcuL6AAA/u1IAACHmaQAAHzDgAAACDucA== Date: Fri, 22 Jan 2016 14:48:48 +0000 Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536B09F96E@IRSMSX106.ger.corp.intel.com> References: <74583418c4374c349bfdea0c59b84118@XCH-RCD-016.cisco.com> <1A27633A6DA49C4A92FCD5D4312DBF536B09F7A4@IRSMSX106.ger.corp.intel.com> <27428043.8pduO1a1Qt@xps13> In-Reply-To: <27428043.8pduO1a1Qt@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWU3NGJhYTQtYjk2MC00ODMxLWFhMmMtMGNhNzgxMmY5OTQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS40LjEwLjE5IiwiVHJ1c3RlZExhYmVsSGFzaCI6InZRNDhsRGxXZGpVeGFpOWJFTmwrXC9QR1NoZ2NITmNpS1o5c29UdlJtaXNjPSJ9 x-ctpclassification: CTP_PUBLIC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] Future Direction for rte_eth_stats_get() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2016 14:48:53 -0000 > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, January 22, 2016 2:44 PM > To: Tahhan, Maryam ; David Harton > (dharton) > Cc: dev@dpdk.org; olivier.matz@6wind.com; Van Haaren, Harry > > Subject: Re: [dpdk-dev] Future Direction for rte_eth_stats_get() >=20 > 2016-01-22 14:18, Tahhan, Maryam: > > So what can be enabled again in struct rte_eth_stats from what was > already there is the equivalent of: > > * rx_length_errors > > * rx_crc_errors > > * rx_missed_errors - the deprecation notice was removed for this > field. > > * multicast > > > > What should be added in to distinguish between errors and drops. > struct rte_eth_stats : > > * rx_errors > > * tx_errors > > > > As for the detailed rx errors and tx errors I'm open to feedback from > you folks as to what should go in and what is too detailed. These > weren't in struct rte_eth_stats previously, they are available through > xstats and are uniformly named across the drivers. Oliver + Harry any > thoughts? > > > > David I assume you are looking for all the missing fields to be added? >=20 > They are not missing. They just not exactly match ones having a long > history in Linux kernel. > Please let's avoid to blindly mimic others without thinking about > modern needs. >=20 My bad wording - I apologise, but I agree we should consider what makes sen= se and what doesn't. > > > > From: David Harton > > > > > Is there a reason the stats have been deprecated? Why not > keep > > > > > the stats in line with the standard linux practices such as > > > > > rtnl_link_stats64?