From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 23BF828F2 for ; Tue, 22 Mar 2016 16:25:25 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 22 Mar 2016 08:23:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,377,1455004800"; d="scan'208";a="71171677" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga004.fm.intel.com with ESMTP; 22 Mar 2016 08:23:23 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.172]) by IRSMSX108.ger.corp.intel.com ([169.254.11.13]) with mapi id 14.03.0248.002; Tue, 22 Mar 2016 15:23:22 +0000 From: "Tahhan, Maryam" To: Thomas Monjalon , Igor Ryzhov CC: "dev@dpdk.org" , "olivier.matz@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter Thread-Index: AQHRgGwNSpUI5jCslkKcXWT2HxGK659lm7WA Date: Tue, 22 Mar 2016 15:23:22 +0000 Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536B10163B@IRSMSX106.ger.corp.intel.com> References: <1457615010-87436-1-git-send-email-iryzhov@nfware.com> <2180400.M1OUCR6DC3@xps13> In-Reply-To: <2180400.M1OUCR6DC3@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWIwMThjNWMtYzE0Ni00NmM2LTliMDItNzljOTk1NTY5NTZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IktVNnJjRzZwT2dzWXJtekx4d1wvZWZEekJIUU9MbXlUekNZSnpBVk5vS09JPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 15:25:26 -0000 > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, March 17, 2016 4:41 PM > To: Igor Ryzhov > Cc: dev@dpdk.org; Tahhan, Maryam ; > olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH] ethdev: don't count missed packets in > erroneous packets counter >=20 > CC Maryam and Olivier who had discussions about imissed and other > stats: > http://dpdk.org/ml/archives/dev/2015-August/022905.html > http://dpdk.org/ml/archives/dev/2015-September/023351.html > http://dpdk.org/ml/archives/dev/2015-September/023612.html >=20 > 2016-03-10 16:03, Igor Ryzhov: > > Comment for "ierrors" counter says that it counts erroneous received > packets. But for some reason "imissed" counter is added to "ierrors" > counter in most drivers. It is a mistake, because missed packets are > obviously not received. This patch fixes it. >=20 > According to this patch > http://dpdk.org/browse/dpdk/commit/?id=3D70bdb186 > imissed was kept in ierrors because of backward compatibility. > I'm OK to remove imissed from ierrors. >=20 > Fixes: 70bdb18657da ("ethdev: add Rx error counters for missed, badcrc > and badlen packets") > Fixes: 6bfe648406b5 ("i40e: add Rx error statistics") > Fixes: 856505d303f4 ("cxgbe: add port statistics") >=20 > Acked-by: Thomas Monjalon Looks fine, but make sure to add an explicit comment in release notes somew= here to flag the change. In case any apps were accounting for imissed as pa= rt of ierrors like testpmd was:=20 - if (((stats->ierrors - stats->imissed) + stats->rx_nombuf) > 0) { + if ((stats->ierrors + stats->rx_nombuf) > 0) { printf(" RX-error:%"PRIu64"\n", stats->ierrors); printf(" RX-nombufs: %14"PRIu64"\n", stats->rx_nombuf);