From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 13F3A8D9D for ; Mon, 16 May 2016 12:42:44 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 16 May 2016 03:42:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,627,1455004800"; d="scan'208";a="967804833" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 16 May 2016 03:42:43 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.131]) by IRSMSX152.ger.corp.intel.com ([169.254.6.54]) with mapi id 14.03.0248.002; Mon, 16 May 2016 11:42:42 +0100 From: "Tahhan, Maryam" To: "Horton, Remy" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC PATCH v2 0/3] Remove string operations from xstats Thread-Index: AQHRp4gaTK67sNALk0uyQ6JYQOwJcZ+7cCPw Date: Mon, 16 May 2016 10:42:42 +0000 Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536B1BBA07@IRSMSX106.ger.corp.intel.com> References: <1460731462-21229-1-git-send-email-remy.horton@intel.com> <1462533074-1994-1-git-send-email-remy.horton@intel.com> In-Reply-To: <1462533074-1994-1-git-send-email-remy.horton@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWQ3YmRkOTItODhmYi00M2VjLTg0YTYtMWE2NzQ0NWMwYmE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjJIXC9EcG5FYlcxRzcxN3ljc3NKOVVBb1wvY2RTbTVBV2c0Skt6NmFpTVp4OD0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC PATCH v2 0/3] Remove string operations from xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 10:42:45 -0000 > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton > Sent: Friday, May 6, 2016 12:11 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC PATCH v2 0/3] Remove string operations from > xstats >=20 > The current extended ethernet statistics fetching involve doing several > string operations, which causes performance issues if there are lots of > statistics and/or network interfaces. This RFC patchset changes the API > for xstats to use integer identifiers instead of strings and implements t= his > new API for the ixgbe driver. Others drivers to follow. >=20 > -- >=20 > v2 changes: > * Fetching xstats count now seperate API function > * Added #define constants for some magic numbers > * Fixed bug with virtual function count fetching > * For non-xstats-supporting drivers, queue stats returned > * Some refactoring/cleanups > * Removed index assumption from example >=20 >=20 > Remy Horton (3): > rte: change xstats to use integer keys > drivers/net/ixgbe: change xstats to use integer keys > examples/ethtool: add xstats display command >=20 > drivers/net/ixgbe/ixgbe_ethdev.c | 98 > ++++++++++++++++++++++++++++----- > examples/ethtool/ethtool-app/ethapp.c | 57 +++++++++++++++++++ > lib/librte_ether/rte_ethdev.c | 100 > +++++++++++++++++++++++++++++----- > lib/librte_ether/rte_ethdev.h | 55 +++++++++++++++++++ > 4 files changed, 284 insertions(+), 26 deletions(-) >=20 > -- > 2.5.5 Looks Great overall. Is there a need to update prog_guide/poll_mode_drv.rst= with the new mods? BR Maryam