From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maryam.tahhan@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id A6B395A8C
 for <dev@dpdk.org>; Wed, 18 May 2016 10:31:37 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga102.fm.intel.com with ESMTP; 18 May 2016 01:31:37 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,328,1459839600"; d="scan'208";a="983540279"
Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96])
 by fmsmga002.fm.intel.com with ESMTP; 18 May 2016 01:31:35 -0700
Received: from irsmsx106.ger.corp.intel.com ([169.254.8.131]) by
 IRSMSX154.ger.corp.intel.com ([169.254.12.18]) with mapi id 14.03.0248.002;
 Wed, 18 May 2016 09:31:33 +0100
From: "Tahhan, Maryam" <maryam.tahhan@intel.com>
To: "Horton, Remy" <remy.horton@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [RFC PATCH v2 1/3] rte: change xstats to use
 integer keys
Thread-Index: AQHRp4grVj+Tm3e5LkKAHGV1TR8dCZ++b68g
Date: Wed, 18 May 2016 08:31:32 +0000
Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536B1BF2ED@IRSMSX106.ger.corp.intel.com>
References: <1462533074-1994-1-git-send-email-remy.horton@intel.com>
 <1462533074-1994-2-git-send-email-remy.horton@intel.com>
In-Reply-To: <1462533074-1994-2-git-send-email-remy.horton@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjkzYTE5ZTctYmQ4ZS00NWVkLThlYWMtNDQ4MDA5NjA5ZTY4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9HaTBnRkpGUFVmYmJNQzdzelplbUEwdDJKSjlaTzBPaXhPR0tsMUsycWc9In0=
x-ctpclassification: CTP_IC
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [RFC PATCH v2 1/3] rte: change xstats to use integer
 keys
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 18 May 2016 08:31:38 -0000

<snip>
>  					     uint8_t stat_idx,
> @@ -1427,6 +1447,10 @@ struct eth_dev_ops {
>  	eth_stats_reset_t          stats_reset;   /**< Reset generic device
> statistics. */
>  	eth_xstats_get_t           xstats_get;    /**< Get extended device
> statistics. */
>  	eth_xstats_reset_t         xstats_reset;  /**< Reset extended
> device statistics. */
> +	eth_xstats_names_t         xstats_names;
> +	/**< Get names of extended statistics. */
> +	eth_xstats_count_t         xstats_count;
> +	/**< Get number of extended statistics. */

Hi Remy
While reviewing the second patch in this patchset I noticed you aren't actu=
ally using=20
eth_xstats_count_t   xstats_count in the eth_dev_ops to retrieve the count =
in the driver.=20
Do you still need xstats_count?

BR
Maryam
<snip>