From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A01CB1B56D for ; Wed, 10 Oct 2018 14:59:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2018 05:59:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,364,1534834800"; d="scan'208";a="87236162" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 10 Oct 2018 05:50:49 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.34]) by fmsmsx104.amr.corp.intel.com ([169.254.3.197]) with mapi id 14.03.0319.002; Wed, 10 Oct 2018 05:50:49 -0700 From: "Wiles, Keith" To: Raslan Darawsheh CC: Thomas Monjalon , "dev@dpdk.org" , Shahaf Shuler , Ori Kam , "Yigit, Ferruh" Thread-Topic: [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures Thread-Index: AQHUYGdUWBGuC/wah0mdbLiKhXyFa6UY5EUA Date: Wed, 10 Oct 2018 12:50:48 +0000 Message-ID: <1A466485-DCE8-40ED-9DDB-E66A0DB2B4A0@intel.com> References: <1539154988-20652-1-git-send-email-rasland@mellanox.com> In-Reply-To: <1539154988-20652-1-git-send-email-rasland@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.38.137] Content-Type: text/plain; charset="us-ascii" Content-ID: <773EEA9AA8ABDB4DA05B5C9E01BEAF02@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/3] net/tap: add queue and port ids in Rx/Tx queues structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Oct 2018 12:59:07 -0000 > On Oct 10, 2018, at 2:03 AM, Raslan Darawsheh wrot= e: >=20 > Signed-off-by: Raslan Darawsheh This title for the patch is the what we did not why we did it, should that = be changed? To me it does not convey the reason or we would need to add a m= ore complete comment body text to explain why we wanted the change. It is a= bit of nit picking. > --- > drivers/net/tap/rte_eth_tap.c | 3 +++ > drivers/net/tap/rte_eth_tap.h | 3 +++ > 2 files changed, 6 insertions(+) >=20 > diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.= c > index ad5ae98..edfb7da 100644 > --- a/drivers/net/tap/rte_eth_tap.c > +++ b/drivers/net/tap/rte_eth_tap.c > @@ -1293,6 +1293,7 @@ tap_rx_queue_setup(struct rte_eth_dev *dev, > rxq->mp =3D mp; > rxq->trigger_seen =3D 1; /* force initial burst */ > rxq->in_port =3D dev->data->port_id; > + rxq->queue_id =3D rx_queue_id; > rxq->nb_rx_desc =3D nb_desc; > iovecs =3D rte_zmalloc_socket(dev->device->name, sizeof(*iovecs), 0, > socket_id); > @@ -1359,6 +1360,8 @@ tap_tx_queue_setup(struct rte_eth_dev *dev, > return -1; > dev->data->tx_queues[tx_queue_id] =3D &internals->txq[tx_queue_id]; > txq =3D dev->data->tx_queues[tx_queue_id]; > + txq->out_port =3D dev->data->port_id; > + txq->queue_id =3D tx_queue_id; >=20 > offloads =3D tx_conf->offloads | dev->data->dev_conf.txmode.offloads; > txq->csum =3D !!(offloads & > diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.= h > index 44e2773..4502e24 100644 > --- a/drivers/net/tap/rte_eth_tap.h > +++ b/drivers/net/tap/rte_eth_tap.h > @@ -46,6 +46,7 @@ struct rx_queue { > struct rte_mempool *mp; /* Mempool for RX packets */ > uint32_t trigger_seen; /* Last seen Rx trigger value */ > uint16_t in_port; /* Port ID */ > + uint16_t queue_id; /* queue ID*/ > int fd; > struct pkt_stats stats; /* Stats for this RX queue */ > uint16_t nb_rx_desc; /* max number of mbufs available */ > @@ -62,6 +63,8 @@ struct tx_queue { > uint16_t csum:1; /* Enable checksum offloading */ > struct pkt_stats stats; /* Stats for this TX queue */ > struct rte_gso_ctx gso_ctx; /* GSO context */ > + uint16_t out_port; /* Port ID */ > + uint16_t queue_id; /* queue ID*/ > }; >=20 > struct pmd_internals { > --=20 > 2.7.4 >=20 Regards, Keith