From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 93830370 for ; Wed, 6 Apr 2016 11:16:12 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 06 Apr 2016 02:16:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; d="scan'208";a="80020512" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga004.fm.intel.com with ESMTP; 06 Apr 2016 02:16:10 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.239]) by IRSMSX104.ger.corp.intel.com ([169.254.5.87]) with mapi id 14.03.0248.002; Wed, 6 Apr 2016 10:16:09 +0100 From: "Weglicki, MichalX" To: Thomas Monjalon CC: Marc Sune , "Xu, Qian Q" , "Xing, Beilei" , "dev@dpdk.org" , "Ananyev, Konstantin" , "Lu, Wenzhuo" , "Richardson, Bruce" , "Glynn, Michael J" , "Gray, Mark D" Thread-Topic: [dpdk-dev] [PATCH v13 4/8] ethdev: rename link speed constants Thread-Index: AQHRhv7hvDZbPa5evEW5IFky2EYUmJ98rK6A///35oCAABY7oA== Date: Wed, 6 Apr 2016 09:16:08 +0000 Message-ID: <1AFA2937E172CD4DB2FD9318443C060EE957C1@IRSMSX103.ger.corp.intel.com> References: <1458934950-23333-1-git-send-email-thomas.monjalon@6wind.com> <1458955640-22951-5-git-send-email-marcdevel@gmail.com> <1AFA2937E172CD4DB2FD9318443C060EE95711@IRSMSX103.ger.corp.intel.com> <1510689.gPteTu5Ds8@xps13> In-Reply-To: <1510689.gPteTu5Ds8@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v13 4/8] ethdev: rename link speed constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2016 09:16:13 -0000 Hello, = Thank you for your answer. = I didn't mention that patch is cosmetic, rather naming. = But all clear, I somehow missed it 9 months ago, and couldn't find it. = Is there any official place where I can find upcoming ABI & API changes, or= I have to dig through mailing list? = Thank you in advance. = Br, = Michal. = -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] = Sent: Wednesday, April 6, 2016 9:53 AM To: Weglicki, MichalX Cc: Marc Sune ; Xu, Qian Q ; Xing= , Beilei ; dev@dpdk.org; Ananyev, Konstantin ; Lu, Wenzhuo ; Richardson, Br= uce ; Glynn, Michael J ; Gray, Mark D Subject: Re: [dpdk-dev] [PATCH v13 4/8] ethdev: rename link speed constants 2016-04-06 08:34, Weglicki, MichalX: > Hello, = > = > I have a question about this patch. = > = > As far as I see changing ETH_LINK_SPEED_ to ETH_SPEED_NUM_ is rather cosm= etic change, am I right? = No. ETH_LINK_SPEED was used for configuration and reported speed. Now the configuration is done with a bitmap filled with new ETH_LINK_SPEED and the old numerical values are kept for other usages as ETH_SPEED_NUM. > Disadvantage of that is that it breaks compatibility with OVS (compilatio= n) and thus it also breaks backward compatibility between OVS & DPDK. Is it= really necessary? = Yes that's why this change was discussed 9 months ago and announced in the previous release notes. > It would be great to keep ABI & API stable if possible. We try to keep it stable when possible and continue to bring some improveme= nts. -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact = the sender and delete all copies.