From: Yongseok Koh <yskoh@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx: update C compliance standard
Date: Fri, 30 Jun 2017 18:14:56 +0000 [thread overview]
Message-ID: <1C0F2AC4-AF9D-4A02-A35A-F70577FE67B5@mellanox.com> (raw)
In-Reply-To: <c3e5f96d-bc1f-6cf6-b8b3-b5d0a13e3d20@intel.com>
> On Jun 30, 2017, at 10:47 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 6/30/2017 6:19 PM, Adrien Mazarguil wrote:
>> This commit addresses a compilation issue against Glibc >= 2.25, which
>> implements assert() through a nonstandard ({ }) construct. Such constructs
>> can normally not be used without __extension__ keyword when -pedantic is
>> enabled, as is the case when compiling mlx4 and mlx5 PMDs in debug mode.
>>
>> While assert.h checks for the compiler ability to support GNU extensions,
>> Clang, unlike GCC, does not allow the above syntax when combining
>> -std=gnu99 with -pedantic.
>>
>> Work around missing keyword by moving these PMDs to a stricter compliance
>> standard without GNU extensions but properly checked by Glibc. Doing so is
>> supported on the DPDK side since includes have been cleaned up.
>>
>> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
> Applied to dpdk-next-net/master, thanks.
This breaks debug-enabled build of mlx5 as mlx5 isn't ready yet!
Thanks,
Yongseok
next prev parent reply other threads:[~2017-06-30 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 17:19 Adrien Mazarguil
2017-06-30 17:47 ` Ferruh Yigit
2017-06-30 18:14 ` Yongseok Koh [this message]
2017-06-30 18:25 ` Yongseok Koh
2017-07-01 15:58 ` Ferruh Yigit
2017-07-02 0:12 ` Yongseok Koh
2017-07-03 8:27 ` [dpdk-dev] [PATCH] net/mlx5: fix compilation issue in debug mode Adrien Mazarguil
2017-07-03 9:18 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1C0F2AC4-AF9D-4A02-A35A-F70577FE67B5@mellanox.com \
--to=yskoh@mellanox.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=nelio.laranjeiro@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).