From: "Huang, ZhiminX" <zhiminx.huang@intel.com>
To: "Peng, ZhihongX" <zhihongx.peng@intel.com>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Peng, ZhihongX" <zhihongx.peng@intel.com>,
"Wang, Liang-min" <liang-min.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD
Date: Tue, 28 Apr 2020 10:19:55 +0000 [thread overview]
Message-ID: <1DCDE90B92229844B9E6C0E67C1C8D6B046A0B2C@CDSMSX102.ccr.corp.intel.com> (raw)
In-Reply-To: <20200417035212.16587-1-zhihongx.peng@intel.com>
Tested-by: Huang, ZhiminX <zhiminx.huang@intel.com>
Regards,
HuangZhiMin
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhihongx.peng@intel.com
Sent: Friday, April 17, 2020 11:52 AM
To: Ye, Xiaolong <xiaolong.ye@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org; Peng, ZhihongX <zhihongx.peng@intel.com>; Wang, Liang-min <liang-min.wang@intel.com>
Subject: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD
From: Peng Zhihong <zhihongx.peng@intel.com>
DPDK does not implement interrupt mechanism on BSD, so force NIC status synchronization.
Fixes: dc66e5fd01b9 (net/ixgbe: improve link state check on VF)
Cc: liang-min.wang@intel.com
Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 2c5797635..efd8aced4 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4262,6 +4262,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0)
wait = 0;
+/* BSD has no interrupt mechanism, so force NIC status synchronization.
+*/ #ifdef RTE_EXEC_ENV_FREEBSD
+ wait = 1;
+#endif
+
if (vf)
diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
else
--
2.17.1
next prev parent reply other threads:[~2020-04-28 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 3:52 zhihongx.peng
2020-04-28 10:19 ` Huang, ZhiminX [this message]
2020-05-06 5:22 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1DCDE90B92229844B9E6C0E67C1C8D6B046A0B2C@CDSMSX102.ccr.corp.intel.com \
--to=zhiminx.huang@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=liang-min.wang@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiaolong.ye@intel.com \
--cc=zhihongx.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).