From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C441A00BE; Tue, 28 Apr 2020 12:20:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0CE9D1D58C; Tue, 28 Apr 2020 12:20:03 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 769921D411 for ; Tue, 28 Apr 2020 12:20:01 +0200 (CEST) IronPort-SDR: MQdoxres47ot8zPecuqjsFeKrIhzgZnn+69PDgZBkcqG6LcIKBaFI0dH8ipCPrUKGZ1WPHAam7 MwLNN921TqgA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 03:20:00 -0700 IronPort-SDR: KFV/CDVLmUvijOj9B4Jmi+7n/rftHegUvrgyOYx/yuKlT6/AdOdLwfcuqnswy2kpZMkphIfpGk MXAEIEpZvjFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="249133816" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 28 Apr 2020 03:20:00 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 03:20:00 -0700 Received: from cdsmsx152.ccr.corp.intel.com (172.17.4.41) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 28 Apr 2020 03:19:59 -0700 Received: from cdsmsx102.ccr.corp.intel.com ([169.254.2.104]) by CDSMSX152.ccr.corp.intel.com ([169.254.6.50]) with mapi id 14.03.0439.000; Tue, 28 Apr 2020 18:19:57 +0800 From: "Huang, ZhiminX" To: "Peng, ZhihongX" , "Ye, Xiaolong" , "Lu, Wenzhuo" , "Ananyev, Konstantin" CC: "dev@dpdk.org" , "Peng, ZhihongX" , "Wang, Liang-min" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD Thread-Index: AQHWFGz78iGIMklH70iWJ8bLC/5ra6iOY9xg Date: Tue, 28 Apr 2020 10:19:55 +0000 Message-ID: <1DCDE90B92229844B9E6C0E67C1C8D6B046A0B2C@CDSMSX102.ccr.corp.intel.com> References: <20200417035212.16587-1-zhihongx.peng@intel.com> In-Reply-To: <20200417035212.16587-1-zhihongx.peng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.17.6.105] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Huang, ZhiminX Regards, HuangZhiMin -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhihongx.peng@intel.co= m Sent: Friday, April 17, 2020 11:52 AM To: Ye, Xiaolong ; Lu, Wenzhuo ; Ananyev, Konstantin Cc: dev@dpdk.org; Peng, ZhihongX ; Wang, Liang-min= Subject: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD From: Peng Zhihong DPDK does not implement interrupt mechanism on BSD, so force NIC status syn= chronization. Fixes: dc66e5fd01b9 (net/ixgbe: improve link state check on VF) Cc: liang-min.wang@intel.com Signed-off-by: Peng Zhihong --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_eth= dev.c index 2c5797635..efd8aced4 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4262,6 +4262,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, if (wait_to_complete =3D=3D 0 || dev->data->dev_conf.intr_conf.lsc !=3D 0= ) wait =3D 0; =20 +/* BSD has no interrupt mechanism, so force NIC status synchronization.=20 +*/ #ifdef RTE_EXEC_ENV_FREEBSD + wait =3D 1; +#endif + if (vf) diag =3D ixgbevf_check_link(hw, &link_speed, &link_up, wait); else -- 2.17.1