* Re: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD
2020-04-17 3:52 [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD zhihongx.peng
@ 2020-04-28 10:19 ` Huang, ZhiminX
2020-05-06 5:22 ` Ye Xiaolong
1 sibling, 0 replies; 3+ messages in thread
From: Huang, ZhiminX @ 2020-04-28 10:19 UTC (permalink / raw)
To: Peng, ZhihongX, Ye, Xiaolong, Lu, Wenzhuo, Ananyev, Konstantin
Cc: dev, Peng, ZhihongX, Wang, Liang-min
Tested-by: Huang, ZhiminX <zhiminx.huang@intel.com>
Regards,
HuangZhiMin
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhihongx.peng@intel.com
Sent: Friday, April 17, 2020 11:52 AM
To: Ye, Xiaolong <xiaolong.ye@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>
Cc: dev@dpdk.org; Peng, ZhihongX <zhihongx.peng@intel.com>; Wang, Liang-min <liang-min.wang@intel.com>
Subject: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD
From: Peng Zhihong <zhihongx.peng@intel.com>
DPDK does not implement interrupt mechanism on BSD, so force NIC status synchronization.
Fixes: dc66e5fd01b9 (net/ixgbe: improve link state check on VF)
Cc: liang-min.wang@intel.com
Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 2c5797635..efd8aced4 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -4262,6 +4262,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0)
wait = 0;
+/* BSD has no interrupt mechanism, so force NIC status synchronization.
+*/ #ifdef RTE_EXEC_ENV_FREEBSD
+ wait = 1;
+#endif
+
if (vf)
diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
else
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD
2020-04-17 3:52 [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD zhihongx.peng
2020-04-28 10:19 ` Huang, ZhiminX
@ 2020-05-06 5:22 ` Ye Xiaolong
1 sibling, 0 replies; 3+ messages in thread
From: Ye Xiaolong @ 2020-05-06 5:22 UTC (permalink / raw)
To: zhihongx.peng; +Cc: wenzhuo.lu, konstantin.ananyev, dev, liang-min.wang
On 04/16, zhihongx.peng@intel.com wrote:
>From: Peng Zhihong <zhihongx.peng@intel.com>
>
>DPDK does not implement interrupt mechanism on BSD,
>so force NIC status synchronization.
>
>Fixes: dc66e5fd01b9 (net/ixgbe: improve link state check on VF)
>Cc: liang-min.wang@intel.com
>
>Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>index 2c5797635..efd8aced4 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -4262,6 +4262,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
> if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0)
> wait = 0;
>
>+/* BSD has no interrupt mechanism, so force NIC status synchronization. */
>+#ifdef RTE_EXEC_ENV_FREEBSD
>+ wait = 1;
>+#endif
>+
> if (vf)
> diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
> else
>--
>2.17.1
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread