From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jijiang.liu@intel.com> Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5F67858DA for <dev@dpdk.org>; Tue, 27 May 2014 03:51:25 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 26 May 2014 18:51:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,916,1392192000"; d="scan'208";a="537901508" Received: from fmsmsx106.amr.corp.intel.com ([10.19.9.37]) by fmsmga001.fm.intel.com with ESMTP; 26 May 2014 18:51:34 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX106.amr.corp.intel.com (10.19.9.37) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 26 May 2014 18:51:34 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.7]) by shsmsx102.ccr.corp.intel.com ([169.254.2.190]) with mapi id 14.03.0123.003; Tue, 27 May 2014 09:51:32 +0800 From: "Liu, Jijiang" <jijiang.liu@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH 0/3] *** Upgrade NIC share codes *** Thread-Index: AQHPc0Nnuja4xArjUUivBznk0qbXdZtTtGaw Date: Tue, 27 May 2014 01:51:32 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01C79D65@SHSMSX101.ccr.corp.intel.com> References: <1400120294-15871-1-git-send-email-jijiang.liu@intel.com> <1789529.RGC5GB4S3q@xps13> In-Reply-To: <1789529.RGC5GB4S3q@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] *** Upgrade NIC share codes *** X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 27 May 2014 01:51:25 -0000 This is a batch update of the code in DPDK to align it with the latest vers= ions of the common device driver code for Intel network devices, such as is= used in the Linux and BSD drivers. Intel DPDK team get periodic updates fr= om the networking division at Intel, and we apply those without modificatio= ns to the code in the ixgbe and e1000 subfolders of the DPDK codebase. Each= code-drop provides us with the latest device support and bug fixes.=20 The code-drop was tested by the ND team ,and Intel DPDK team receive the co= de-drop without individual commit history, as mentioned earlier, this is a = batch update.=20 Furthermore, before sending patches to dpdk.org, in order to guarantee no n= ew issues are introduced by upgrading, Intel DPDK team has done development= and test of integration, and don't change any source codes in these driver= s in the meantime.=20 At present, the common device code should be treated as read-only, any bugs= found here will be collected and reported to Intel. Thanks Frank -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Monday, May 19, 2014 5:18 PM To: Liu, Jijiang Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/3] *** Upgrade NIC share codes *** Hi Jijiang, I feel there is a lot of important changes in these patches but I cannot ea= sily read them. Splitting in many small patches with nice commit logs would= help a lot. Please refer to http://dpdk.org/dev#send in order to understand what must b= e a good patch. At least, you should make patches for minor changes (whitespace/typo/case),= few patches for new features (e.g. M88E1512, SFP+ laser) and few patches f= or bug fixes (e.g. pll_workaround_i210, locks, fc-autoneg, vf link). Especially, an explanation is needed for locking changes as there were some= work on it in these commits: http://dpdk.org/browse/dpdk/commit/?id=3D4c9d8ed203c1170e4cc11 http://dpdk.org/browse/dpdk/commit/?id=3Df283b30509d2db745e746 "git add -p" could help you to split the changes into several commits. You can check how minor changes in base driver were handled previously. Examples from version 1.5.1: http://dpdk.org/browse/dpdk/commit/?id=3D1558bea6e3723d9c1 http://dpdk.org/browse/dpdk/commit/?id=3D2fd4855f306e9df38 http://dpdk.org/browse/dpdk/commit/?id=3D5037620be576a3c20 http://dpdk.org/browse/dpdk/commit/?id=3D1d2d65121bd10ba95 Thanks -- Thomas