From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4FE035946 for ; Thu, 28 Aug 2014 03:29:40 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 27 Aug 2014 18:33:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,415,1406617200"; d="scan'208";a="590896612" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 27 Aug 2014 18:33:45 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 27 Aug 2014 18:33:45 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 27 Aug 2014 18:33:45 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.198]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.147]) with mapi id 14.03.0195.001; Thu, 28 Aug 2014 09:33:43 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 1/7]i40e:support VxLAN packet identification Thread-Index: AQHPwgd3bWwmRFnOJEO9PaSzQ8V4Y5vlOzKg Date: Thu, 28 Aug 2014 01:33:42 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D631C0@SHSMSX101.ccr.corp.intel.com> References: <1409038294-21693-1-git-send-email-jijiang.liu@intel.com> <1409038294-21693-2-git-send-email-jijiang.liu@intel.com> <1672259.DZkGQ2cZmA@xps13> In-Reply-To: <1672259.DZkGQ2cZmA@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/7]i40e:support VxLAN packet identification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 01:29:40 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, August 27, 2014 10:59 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/7]i40e:support VxLAN packet > identification >=20 > Hi Jijiang, >=20 > 2014-08-26 15:31, Jijiang Liu: > > VxLAN UDP port configuration on i40e, which include > > - VxLAN UDP port initialization > > - add APIs to configure VxLAN UDP port >=20 > Actually you should explain that you introduce tunnels and first one is V= xLAN. >=20 > > lib/librte_ether/rte_ethdev.c | 63 ++++++++++++ > > lib/librte_ether/rte_ethdev.h | 76 ++++++++++++++ > > lib/librte_ether/rte_ether.h | 10 ++ > > lib/librte_pmd_i40e/i40e_ethdev.c | 199 > ++++++++++++++++++++++++++++++++++++- > > lib/librte_pmd_i40e/i40e_ethdev.h | 5 + >=20 > Changing ethdev API is so sensible that it deserves a separated commit. >=20 > Code seems OK. >=20 You meant that I should split the patch into two patches, one is for change= s in librte_ether, other is for=20 Change in librte_pmd_i40e? Or one for VxLAN UDP port initialization, other = is for add APIs to configure VxLAN UDP port? -- Jijiang Liu