From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jijiang.liu@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 93ABD5946
 for <dev@dpdk.org>; Thu, 28 Aug 2014 12:58:44 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga103.fm.intel.com with ESMTP; 28 Aug 2014 03:54:48 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,417,1406617200"; d="scan'208";a="582831525"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by fmsmga001.fm.intel.com with ESMTP; 28 Aug 2014 04:02:47 -0700
Received: from fmsmsx101.amr.corp.intel.com (10.19.9.52) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Thu, 28 Aug 2014 04:02:47 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 FMSMSX101.amr.corp.intel.com (10.19.9.52) with Microsoft SMTP Server (TLS) id
 14.3.195.1; Thu, 28 Aug 2014 04:02:47 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.198]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.147]) with mapi id 14.03.0195.001;
 Thu, 28 Aug 2014 19:02:45 +0800
From: "Liu, Jijiang" <jijiang.liu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet
 filter in librte_ether
Thread-Index: AQHPwpt2SLkk1INR7Euh39mpJ3z/YZvls7fA
Date: Thu, 28 Aug 2014 11:02:44 +0000
Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D633CF@SHSMSX101.ccr.corp.intel.com>
References: <1409038294-21693-1-git-send-email-jijiang.liu@intel.com>
 <3586297.ZW2M4AoP7m@xps13>
 <1ED644BD7E0A5F4091CF203DAFB8E4CC01D6319C@SHSMSX101.ccr.corp.intel.com>
 <3070853.Eook8YoHL0@xps13>
In-Reply-To: <3070853.Eook8YoHL0@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet
 filter in librte_ether
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Aug 2014 10:58:45 -0000

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, August 28, 2014 4:37 PM
> To: Liu, Jijiang
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet f=
ilter
> in librte_ether
>=20
> 2014-08-28 00:55, Liu, Jijiang:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > I wonder if we could use a common function to set all kind of filters=
?
> > >
> > > Thoughts are welcome.
> >
> > The rte_eth_dev_tunnel_filter_set() is a common filter function for
> > tunneling packet, which can set all kind of filters.
>=20
> I understand that. But my question was: could we have common functions fo=
r
> tunnel filters and (existing) generic filters?
>=20
> --
> Thomas
Tunneling packet is encapsulated format, in order to extend another tunneli=
ng type support and distinguish between tunneling and non-tunneling packet,
we had better provide independent common filter API.=20
The existing generic filter function is related to normal L2 packet filter(=
non-tunneling packet). If there are two kind of filter APIs, one is for nor=
mal L2 packet,=20
other is for tunneling packet, which will make user more clear when and how=
 to use them. =20

Thanks
Jijiang Liu