From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2790C6828 for ; Mon, 10 Nov 2014 06:54:41 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 09 Nov 2014 22:04:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="414033873" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by FMSMGA003.fm.intel.com with ESMTP; 09 Nov 2014 21:55:34 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 10 Nov 2014 14:03:34 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.130]) by shsmsx102.ccr.corp.intel.com ([169.254.2.136]) with mapi id 14.03.0195.001; Mon, 10 Nov 2014 14:03:32 +0800 From: "Liu, Jijiang" To: Olivier MATZ Thread-Topic: [dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum offload Thread-Index: AQHP8Yux0VUY397yik2xjVM3DjesSpxPpsiAgAGaY5CAABv8AIAIEl8g Date: Mon, 10 Nov 2014 06:03:32 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D8F399@SHSMSX101.ccr.corp.intel.com> References: <1414376006-31402-1-git-send-email-jijiang.liu@intel.com> <1414376006-31402-11-git-send-email-jijiang.liu@intel.com> <54588BF7.309@6wind.com> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D8510E@SHSMSX101.ccr.corp.intel.com> <5459FBB2.1040408@6wind.com> In-Reply-To: <5459FBB2.1040408@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2014 05:54:42 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Wednesday, November 5, 2014 6:28 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checks= um > offload >=20 > Hi Jijiang, >=20 > Thank you for your answer. Please find some comments below. >=20 >=20 > Another thing is surprising me. >=20 > - if PKT_TX_VXLAN_CKSUM is not set (legacy use case), then the > driver use l2_len and l3_len to offload inner IP/UDP/TCP checksums. If the flag is not set, and imply that it is not VXLAN packet,=20 and do TX checksum offload as regular packet. > - if PKT_TX_VXLAN_CKSUM is set, then the driver has to use > inner_l{23}_len instead of l{23}_len for the same operation. Your understanding is not fully correct. The l{23}_len is still used for TX checksum offload, please refer to i40e_t= xd_enable_checksum() implementation. > Adding PKT_TX_VXLAN_CKSUM changes the semantic of l2_len and l3_len. > To fix this, I suggest to remove the new fields inner_l{23}_len then add > outer_l{23}_len instead. Therefore, the semantic of l2_len and l3_len wou= ld not > change, and a driver would always use the same field for a specific offlo= ad. Oh... > For my TSO development, I will follow the current semantic. For TSO, you still can use l{2,3} _len . When I develop tunneling TSO, I will use inner_l3_len/inner_l4_len. >=20