From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8832A5ADD for ; Fri, 23 Jan 2015 09:06:31 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 23 Jan 2015 00:00:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="444081718" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by FMSMGA003.fm.intel.com with ESMTP; 22 Jan 2015 23:53:03 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 23 Jan 2015 16:06:23 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.64]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.231]) with mapi id 14.03.0195.001; Fri, 23 Jan 2015 16:06:21 +0800 From: "Liu, Jijiang" To: Olivier Matz , "Zhang, Helin" Thread-Topic: [RFC 04/16] i40e: remove the use of PKT_TX_UDP_TUNNEL_PKT flag Thread-Index: AQHQNdMnOU6MMCBSoke6hM9aJHGnDpzNWGYw Date: Fri, 23 Jan 2015 08:06:21 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01DB631A@SHSMSX101.ccr.corp.intel.com> References: <1421883395-27235-1-git-send-email-olivier.matz@6wind.com> <1421883395-27235-5-git-send-email-olivier.matz@6wind.com> In-Reply-To: <1421883395-27235-5-git-send-email-olivier.matz@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [RFC 04/16] i40e: remove the use of PKT_TX_UDP_TUNNEL_PKT flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jan 2015 08:06:32 -0000 Hi, > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Thursday, January 22, 2015 7:36 AM > To: dev@dpdk.org > Cc: olivier.matz@6wind.com; Ananyev, Konstantin; Liu, Jijiang > Subject: [RFC 04/16] i40e: remove the use of PKT_TX_UDP_TUNNEL_PKT flag >=20 > The definition of the flag in rte_mbuf.h was: > TX packet is an UDP tunneled packet. It must be specified when using > outer checksum offload (PKT_TX_OUTER_IP_CKSUM) >=20 > This flag was used to tell the NIC that the offload type is UDP > (I40E_TXD_CTX_UDP_TUNNELING flag). In the datasheet, it says it's require= d > to specify the tunnel type in the register. However, some tests (see [1]) > showed that it also works without this flag. >=20 > Moreover, it is not explained how the hardware use this information. From= a > network perspective, this information is useless for calculating the oute= r IP > checksum as it does not depend on the payload. >=20 > Having this flag in the API would force the application to specify the tu= nnel > type for something that looks only useful for this PMD. It will limit the > number of possible tunnel types (we would need a flag for each tunnel typ= e) > and therefore prevent to support outer IP checksum for proprietary tunnel= s. >=20 > Finally, if a hardware advertises "I support outer IP checksum", it must = be > supported for any payload types. >=20 > [1] http://dpdk.org/ml/archives/dev/2015-January/011380.html >=20 > Signed-off-by: Olivier Matz > --- > lib/librte_pmd_i40e/i40e_rxtx.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_r= xtx.c > index 9acdeee..0786255 100644 > --- a/lib/librte_pmd_i40e/i40e_rxtx.c > +++ b/lib/librte_pmd_i40e/i40e_rxtx.c > @@ -482,7 +482,7 @@ i40e_txd_enable_checksum(uint64_t ol_flags, > } >=20 > /* UDP tunneling packet TX checksum offload */ > - if (unlikely(ol_flags & PKT_TX_UDP_TUNNEL_PKT)) { > + if (unlikely(ol_flags & PKT_TX_OUTER_IP_CKSUM)) { This way will disable FVL TX checksum offload capability of inner IP and i= nner L4 using B.1 method. Again, the B.1 in http://dpdk.org/ml/archives/dev/2014-December/009213.html= should be supported and allowed. Helin, you are i40e maintainer, what's your point? > *td_offset |=3D (outer_l2_len >> 1) > << I40E_TX_DESC_LENGTH_MACLEN_SHIFT; > @@ -497,7 +497,6 @@ i40e_txd_enable_checksum(uint64_t ol_flags, > /* Now set the ctx descriptor fields */ > *cd_tunneling |=3D (outer_l3_len >> 2) << > I40E_TXD_CTX_QW0_EXT_IPLEN_SHIFT | > - I40E_TXD_CTX_UDP_TUNNELING | > (l2_len >> 1) << > I40E_TXD_CTX_QW0_NATLEN_SHIFT; >=20 > @@ -1165,8 +1164,7 @@ i40e_calc_context_desc(uint64_t flags) { > uint64_t mask =3D 0ULL; >=20 > - if (flags | PKT_TX_UDP_TUNNEL_PKT) > - mask |=3D PKT_TX_UDP_TUNNEL_PKT; > + mask |=3D PKT_TX_OUTER_IP_CKSUM; >=20 > #ifdef RTE_LIBRTE_IEEE1588 > mask |=3D PKT_TX_IEEE1588_TMST; > -- > 2.1.3