From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 17A9E8DB5 for ; Wed, 11 Nov 2015 09:38:39 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 11 Nov 2015 00:38:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,274,1444719600"; d="scan'208";a="847731649" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 11 Nov 2015 00:38:39 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 11 Nov 2015 00:38:38 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.83]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.223]) with mapi id 14.03.0248.002; Wed, 11 Nov 2015 16:38:30 +0800 From: "Liu, Jijiang" To: Yuanhan Liu , "Michael S. Tsirkin" Thread-Topic: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload capabilities Thread-Index: AQHRHEv/9kTOw3jhcUuIrjChZUXedp6V9/cAgACHpbA= Date: Wed, 11 Nov 2015 08:38:29 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BDA719@SHSMSX101.ccr.corp.intel.com> References: <1447224046-1169-1-git-send-email-jijiang.liu@intel.com> <1447224046-1169-8-git-send-email-jijiang.liu@intel.com> <20151111083118.GA2326@yliu-dev.sh.intel.com> In-Reply-To: <20151111083118.GA2326@yliu-dev.sh.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2015 08:38:40 -0000 > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Wednesday, November 11, 2015 4:31 PM > To: Liu, Jijiang; Michael S. Tsirkin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 7/8] virtio/lib:add virtio guest offloa= d > capabilities >=20 > On Wed, Nov 11, 2015 at 02:40:45PM +0800, Jijiang Liu wrote: > > Add virtio guest offload capabilities. > > > > Signed-off-by: Jijiang Liu > > --- > > lib/librte_vhost/virtio-net.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/lib/librte_vhost/virtio-net.c > > b/lib/librte_vhost/virtio-net.c index 81bd309..839a333 100644 > > --- a/lib/librte_vhost/virtio-net.c > > +++ b/lib/librte_vhost/virtio-net.c > > @@ -80,7 +80,10 @@ static struct virtio_net_config_ll *ll_root; > > (1ULL << > VHOST_USER_F_PROTOCOL_FEATURES) | \ > > (1ULL << VIRTIO_NET_F_HOST_TSO4) | \ > > (1ULL << VIRTIO_NET_F_HOST_TSO6) | \ > > - (1ULL << VIRTIO_NET_F_CSUM)) > > + (1ULL << VIRTIO_NET_F_CSUM) | \ > > + (1ULL << VIRTIO_NET_F_GUEST_CSUM) | \ > > + (1ULL << VIRTIO_NET_F_GUEST_TSO4) | \ > > + (1ULL << VIRTIO_NET_F_GUEST_TSO6)) >=20 > I don't think we need that, and it might be wrong to set those fields at = vhost. >=20 > And, TBH, I am not 100% sure that I understand what those flags truely ar= e > and for. All I know is that they seem have something to do with QEMU/TAP > device. According to virtio standard, those fileds should be set. Yes, I'd like to listen other guys comments. > Hopefully the virtio expert, Michael, could shine some lights on that. >=20 > --yliu >=20 > > > > static uint64_t VHOST_FEATURES =3D VHOST_SUPPORTED_FEATURES; > > > > -- > > 1.7.7.6