From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 30FF62716 for ; Tue, 15 Dec 2015 02:18:00 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 14 Dec 2015 17:18:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,429,1444719600"; d="scan'208";a="707497799" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 14 Dec 2015 17:17:58 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 14 Dec 2015 17:17:58 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.190]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.28]) with mapi id 14.03.0248.002; Tue, 15 Dec 2015 09:17:56 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_tunnel_flow Thread-Index: AQHRNoDu9FtaEUvJ+EO4iW5oA7PnXp7LOJ4g Date: Tue, 15 Dec 2015 01:17:55 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BF0335@SHSMSX101.ccr.corp.intel.com> References: <1449639461-9718-1-git-send-email-jijiang.liu@intel.com> <2136605.pcfb1tFB10@xps13> In-Reply-To: <2136605.pcfb1tFB10@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_tunnel_flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 01:18:00 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Monday, December 14, 2015 11:04 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > rte_eth_tunnel_flow >=20 > 2015-12-09 13:37, Jijiang Liu: > > The struct 'rte_eth_tunnel_flow' is only used by struct > > 'rte_eth_fdir_flow' now, but its name is generic, and I plan to extend = new > fileds like below to support generic configuration for tunneling packet. >=20 > You have not explained what the changes are for. > So it's really difficult to have an opinion. > Please describe an use case. For i40e flow director, it can use more fields such as inner destination IP= , inner MAC outer destination MAC and outer destination IP to do classifica= tion for tunneling packet. Otherwise, we also can use this structure to store tunnel flow configuratio= n, not just for classification. > PS: "filed" -> "field"