From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7137111F5 for ; Tue, 15 Dec 2015 03:05:36 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 14 Dec 2015 18:05:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,429,1444719600"; d="scan'208";a="860792123" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 14 Dec 2015 18:05:35 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 14 Dec 2015 18:05:35 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 14 Dec 2015 18:05:34 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.190]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.28]) with mapi id 14.03.0248.002; Tue, 15 Dec 2015 10:05:32 +0800 From: "Liu, Jijiang" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_tunnel_flow Thread-Index: AQHRNoDu9FtaEUvJ+EO4iW5oA7PnXp7LOJ4ggAATDzA= Date: Tue, 15 Dec 2015 02:05:31 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BF0387@SHSMSX101.ccr.corp.intel.com> References: <1449639461-9718-1-git-send-email-jijiang.liu@intel.com> <2136605.pcfb1tFB10@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC22BF0335@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC22BF0335@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct rte_eth_tunnel_flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2015 02:05:36 -0000 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Monday, December 14, 2015 11:04 PM > > To: Liu, Jijiang > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for struct > > rte_eth_tunnel_flow > > > > 2015-12-09 13:37, Jijiang Liu: > > > The struct 'rte_eth_tunnel_flow' is only used by struct > > > 'rte_eth_fdir_flow' now, but its name is generic, and I plan to > > > extend new > > fileds like below to support generic configuration for tunneling packet= . > > > > You have not explained what the changes are for. > > So it's really difficult to have an opinion. > > Please describe an use case. > For i40e flow director, it can use more fields such as inner destination = IP, > inner MAC outer destination MAC and outer destination IP to do > classification for tunneling packet. > Otherwise, we also can use this structure to store tunnel flow configurat= ion, > not just for classification. >=20 > > PS: "filed" -> "field" After aligning with Jingjing, she have already sent ABI change announcement= for struct 'rte_eth_fdir_flow'to extend input set of FD, refer to[1]. And change of struct 'rte_eth_tunnel_flow' I want to announce can be includ= ed in hers, so I don't need to announce it again. Thanks.=20 [1]http://dpdk.org/ml/archives/dev/2015-November/027915.html