From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <nikhil.rao@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id 446BC98
for <dev@dpdk.org>; Thu, 16 Aug 2018 08:19:42 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
15 Aug 2018 23:19:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.53,246,1531810800"; d="scan'208";a="65586614"
Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130])
by orsmga008.jf.intel.com with ESMTP; 15 Aug 2018 23:19:41 -0700
Received: from orsmsx110.amr.corp.intel.com ([169.254.10.41]) by
ORSMSX103.amr.corp.intel.com ([169.254.5.166]) with mapi id 14.03.0319.002;
Wed, 15 Aug 2018 23:19:41 -0700
From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net"
<thomas@monjalon.net>, "Mcnamara, John" <john.mcnamara@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>, "Yigit, Ferruh"
<ferruh.yigit@intel.com>, "stephen@networkplumber.org"
<stephen@networkplumber.org>, "toggle-mailboxes@hmswarspite.think-freely.org"
<toggle-mailboxes@hmswarspite.think-freely.org>
Thread-Topic: [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition
Thread-Index: AQHUM4J93M34Rw5YzkCGmzvOLBwy3qS/i4aAgAFAMQCAAE3BgIAA0VaQ
Date: Thu, 16 Aug 2018 06:19:40 +0000
Message-ID: <1F668163772FA946975B9466A9DFF729ED33A79E@ORSMSX110.amr.corp.intel.com>
References: <20180814105208.GA24870@hmswarspite.think-freely.org>
<1534313442-26927-1-git-send-email-nikhil.rao@intel.com>
<20180815104859.GA3846@hmswarspite.think-freely.org>
In-Reply-To: <20180815104859.GA3846@hmswarspite.think-freely.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [10.22.254.138]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI
symbol addition
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Aug 2018 06:19:42 -0000
> -----Original Message-----
> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Wednesday, August 15, 2018 4:19 PM
> To: Rao, Nikhil <nikhil.rao@intel.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; Mcnamara, John
> <john.mcnamara@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> stephen@networkplumber.org; toggle-mailboxes@hmswarspite.think-
> freely.org
> Subject: Re: [PATCH v9] checkpatches.sh: Add checks for ABI symbol additi=
on
>=20
>=20
>=20
> Thanks, I think I made a mistake in how I detect section names in the awk
> script. The rule assumes that the entire section is getting added (i.e. =
we are
> adding the EXPERIMENTAL section as a whole unit, hence the starting a lin=
e
> with
> + to id the section name, and thats not the case here. I think the rule
> + needs
> to be any line in a map file that ends with a { (based on our coding prac=
tice), is
> a section start, and the section name is the next to the last field in th=
e line (i.e.
> $(NF-1) ). Please apply the patch below and confirm that this works for =
you.
>=20
> Best
> Neil
>=20
>=20
Thanks for the fix, it works.
Nikhil
>=20
> diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-
> change.sh index daaf45e14..cf9cfc745 100755
> --- a/devtools/check-symbol-change.sh
> +++ b/devtools/check-symbol-change.sh
> @@ -25,14 +25,14 @@ build_map_changes()
> # supresses the subordonate rules below
> /[-+] a\/.*\.^(map)/ {in_map=3D0}
>=20
> - # Triggering this rule, which starts a line with a + and ends it
> + # Triggering this rule, which starts a line and ends it
> # with a { identifies a versioned section. The section name is
> # the rest of the line with the + and { symbols remvoed.
> # Triggering this rule sets in_sec to 1, which actives the
> # symbol rule below
> - /+.*{/ {gsub("+","");
> + /^.*{/ {
> if (in_map =3D=3D 1) {
> - sec=3D$1; in_sec=3D1;
> + sec=3D$(NF-1); in_sec=3D1;
> }
> }
>=20