From: "Rao, Nikhil" <nikhil.rao@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
"anoob.joseph@caviumnetworks.com"
<anoob.joseph@caviumnetworks.com>, "dev@dpdk.org" <dev@dpdk.org>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH v2] examples/eventdev_pipeline: add Tx adapter support
Date: Wed, 3 Oct 2018 08:47:25 +0000 [thread overview]
Message-ID: <1F668163772FA946975B9466A9DFF729ED364733@ORSMSX107.amr.corp.intel.com> (raw)
In-Reply-To: <20180928111542.GA8468@jerin>
> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Friday, September 28, 2018 4:46 PM
> To: Rao, Nikhil <nikhil.rao@intel.com>
> Cc: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>; Van Haaren,
> Harry <harry.van.haaren@intel.com>; anoob.joseph@caviumnetworks.com;
> dev@dpdk.org
> Subject: Re: [PATCH v2] examples/eventdev_pipeline: add Tx adapter support
>
> -----Original Message-----
> > Date: Wed, 26 Sep 2018 18:26:37 +0530
> > From: "Rao, Nikhil" <nikhil.rao@intel.com>
> > To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
> > jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
> > anoob.joseph@caviumnetworks.com
> > CC: dev@dpdk.org, "Rao, Nikhil" <nikhil.rao@intel.com>
> > Subject: Re: [PATCH v2] examples/eventdev_pipeline: add Tx adapter
> > support
> > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0)
> > Gecko/20100101
> > Thunderbird/60.0
> >
> > On 9/24/2018 3:42 PM, Pavan Nikhilesh wrote:
> > > Redo the worker pipelines and offload transmission to service cores
> > > seamlessly through Tx adapter.
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > > ---
> > > v2 Changes:
> > > - Updated enqueue,dequeue depth thresholds.
> > > - remove redundant capability checks.
> >
> > Reviewed-by: Nikhil Rao <nikhil.rao@intel.com>
> > Tested-by: Nikhil Rao <nikhil.rao@intel.com>
>
>
> Applied to dpdk-next-eventdev/master. Thanks.
>
Hi Pavan,
A couple of questions:
1. For the generic pipeline case with the SW PMD, the tx adapter port's default dequeue depth value causes performance regression from ~12 mpps to 7mpps. While the -c command line argument is also applicable to the tx adapter's port, since packet flow to the tx adapter port is of a different nature than the worker ports, how about adding the dequeue depth for the tx adapter port as a separate command line argument with a default value of 128 ?
2. -n parameter and stats for the generic pipeline that were available in the app previously do not work, do you plan to add this functionality ?
Thanks,
Nikhil
prev parent reply other threads:[~2018-10-03 8:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 13:45 [dpdk-dev] [PATCH] " Pavan Nikhilesh
2018-09-17 14:17 ` Jerin Jacob
2018-09-19 2:54 ` Rao, Nikhil
2018-09-19 10:42 ` Pavan Nikhilesh
2018-09-20 2:18 ` Rao, Nikhil
2018-09-21 7:44 ` Rao, Nikhil
2018-09-24 9:51 ` Pavan Nikhilesh
2018-09-24 10:12 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh
2018-09-26 12:56 ` Rao, Nikhil
2018-09-28 11:15 ` Jerin Jacob
2018-10-03 8:47 ` Rao, Nikhil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1F668163772FA946975B9466A9DFF729ED364733@ORSMSX107.amr.corp.intel.com \
--to=nikhil.rao@intel.com \
--cc=anoob.joseph@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).