From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 92F773256 for ; Mon, 10 Dec 2018 06:43:39 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2018 21:43:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,337,1539673200"; d="scan'208";a="109089422" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga003.jf.intel.com with ESMTP; 09 Dec 2018 21:43:38 -0800 Received: from orsmsx122.amr.corp.intel.com (10.22.225.227) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Dec 2018 21:43:37 -0800 Received: from orsmsx110.amr.corp.intel.com ([169.254.10.212]) by ORSMSX122.amr.corp.intel.com ([169.254.11.103]) with mapi id 14.03.0415.000; Sun, 9 Dec 2018 21:43:38 -0800 From: "Rao, Nikhil" To: Stephen Hemminger CC: "Dumitrescu, Cristian" , "Singh, Jasvinder" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ethdev: support double precision RED queue weight Thread-Index: AQHUh6hGZNKORyos/kqiWAO0xdfBoqVmy+KAgBCunFA= Date: Mon, 10 Dec 2018 05:43:37 +0000 Message-ID: <1F668163772FA946975B9466A9DFF729ED3AF9EF@ORSMSX110.amr.corp.intel.com> References: <1543470882-145287-1-git-send-email-nikhil.rao@intel.com> <20181128221245.017eadcf@xeon-e3> In-Reply-To: <20181128221245.017eadcf@xeon-e3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGFiODhlMmItOGQyMS00MzcyLWE1OTEtNWQ3NWY1MWNjNDMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQnphOFwvd055M0U3Z2pBMjVSOFBDZXFvbXVYOEhjbDk4ZEZKY3pQRU45b1UrUEI3MWxqU1l1RXNoSTZkR25TSVgifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: support double precision RED queue weight X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 05:43:40 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, November 29, 2018 11:43 AM > To: Rao, Nikhil > Cc: Dumitrescu, Cristian ; Singh, Jasvinde= r > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ethdev: support double precision RED queu= e > weight >=20 > On Thu, 29 Nov 2018 11:24:42 +0530 > Nikhil Rao wrote: >=20 > > RED queue weight is currently specified as a negated log of 2. > > > > Add support for RED queue weight to be specified in double precision > > and TM capability flags for double precision and negated log2 RED > > queue weight support. > > > > Signed-off-by: Nikhil Rao >=20 > Since this is an ABI break anyway, why not just commit to the new format? Hi Stephen, Can you please provide more detail on your comment ? are you suggesting re= placing the wq_log2/wq_dp with a double ? Thanks, Nikhil