From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8F495A046B for ; Mon, 24 Jun 2019 08:13:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7B931BF4F; Mon, 24 Jun 2019 08:13:54 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9D0C91BF47; Mon, 24 Jun 2019 08:13:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jun 2019 23:13:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,411,1557212400"; d="scan'208";a="359906700" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga006.fm.intel.com with ESMTP; 23 Jun 2019 23:13:52 -0700 Received: from orsmsx154.amr.corp.intel.com (10.22.226.12) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 23 Jun 2019 23:13:52 -0700 Received: from orsmsx122.amr.corp.intel.com ([169.254.11.7]) by ORSMSX154.amr.corp.intel.com ([169.254.11.187]) with mapi id 14.03.0439.000; Sun, 23 Jun 2019 23:13:52 -0700 From: "Rao, Nikhil" To: "jerinj@marvell.com" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eventdev: fix doxygen comment Thread-Index: AQHVJnXMjmXC4qc1MUevHtVpUgZcJaaqV8MQ Date: Mon, 24 Jun 2019 06:13:51 +0000 Message-ID: <1F668163772FA946975B9466A9DFF729EDE624AA@ORSMSX122.amr.corp.intel.com> References: <20190619080309.32188-1-jerinj@marvell.com> In-Reply-To: <20190619080309.32188-1-jerinj@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eventdev: fix doxygen comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jerin, > -----Original Message----- > From: jerinj@marvell.com [mailto:jerinj@marvell.com] > Sent: Wednesday, June 19, 2019 1:33 PM > To: dev@dpdk.org; Jerin Jacob > Cc: stable@dpdk.org; Rao, Nikhil > Subject: [dpdk-dev] [PATCH] eventdev: fix doxygen comment >=20 > From: Jerin Jacob >=20 > Update rte_eventdev.h file description to adapt to Tx adapter changes. >=20 > Fixes: c9bf83947e2e ("eventdev: add eth Tx adapter APIs") > Cc: stable@dpdk.org > Cc: Nikhil Rao >=20 > Signed-off-by: Jerin Jacob > --- > lib/librte_eventdev/rte_eventdev.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/librte_eventdev/rte_eventdev.h > b/lib/librte_eventdev/rte_eventdev.h > index 517cd8083..a5ec5d99b 100644 > --- a/lib/librte_eventdev/rte_eventdev.h > +++ b/lib/librte_eventdev/rte_eventdev.h > @@ -181,9 +181,9 @@ > * The *dequeue* operation gets one or more events from the event ports. > * The application process the events and send to downstream event queue > through > * rte_event_enqueue_burst() if it is an intermediate stage of event > processing, > - * on the final stage, the application may send to different subsystem l= ike > - * ethdev to send the packet/event on the wire using ethdev > - * rte_eth_tx_burst() API. > + * on the final stage, the application may send to Tx adapter for > maintaining > + * the ingress order and then to send the packet/event on the wire using > + * rte_event_eth_tx_adapter_enqueue() API. Since the change above is applicable only if eventdev supports the RTE_EVE= NT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT, can we rephrase to include both cases = ? The Tx adapter documentation has the details, it would be good to cross = reference it. Thanks, Nikhil > * > * The point at which events are scheduled to ports depends on the devic= e. > * For hardware devices, scheduling occurs asynchronously without any > software > -- > 2.21.0