From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC7D4A3160 for ; Thu, 10 Oct 2019 12:06:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4761F1E969; Thu, 10 Oct 2019 12:06:08 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8C7F81E964 for ; Thu, 10 Oct 2019 12:06:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2019 03:06:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,279,1566889200"; d="scan'208";a="218972892" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga004.fm.intel.com with ESMTP; 10 Oct 2019 03:06:05 -0700 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 10 Oct 2019 03:06:04 -0700 Received: from orsmsx122.amr.corp.intel.com ([169.254.11.32]) by ORSMSX157.amr.corp.intel.com ([169.254.9.232]) with mapi id 14.03.0439.000; Thu, 10 Oct 2019 03:06:04 -0700 From: "Rao, Nikhil" To: Nipun Gupta , "dev@dpdk.org" CC: "jerinj@marvell.com" , "aconole@redhat.com" , "pbhagavatula@marvell.com" , "skori@marvell.com" , "hemant.agrawal@nxp.com" , "Richardson, Bruce" , "Kovacevic, Marko" , "orika@mellanox.com" , "Nicolau, Radu" , "Kantecki, Tomasz" , "Van Haaren, Harry" Thread-Topic: [PATCH v4] eventdev: flag to identify same destined packets enqueue Thread-Index: AQHVfnXs/XfVDd2AwUmUtzwlWk8xMKdTpmoA Date: Thu, 10 Oct 2019 10:06:04 +0000 Message-ID: <1F668163772FA946975B9466A9DFF729EDEE4BAD@ORSMSX122.amr.corp.intel.com> References: <20191001064641.28404-1-nipun.gupta@nxp.com> <20191009073236.32661-1-nipun.gupta@nxp.com> In-Reply-To: <20191009073236.32661-1-nipun.gupta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] eventdev: flag to identify same destined packets enqueue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Nipun, > -----Original Message----- > From: Nipun Gupta [mailto:nipun.gupta@nxp.com] > Sent: Wednesday, October 9, 2019 1:03 PM > To: dev@dpdk.org > Cc: jerinj@marvell.com; aconole@redhat.com; pbhagavatula@marvell.com; > skori@marvell.com; hemant.agrawal@nxp.com; Richardson, Bruce > ; Kovacevic, Marko > ; orika@mellanox.com; Nicolau, Radu > ; Kantecki, Tomasz ; > Van Haaren, Harry ; Rao, Nikhil > ; Nipun Gupta > Subject: [PATCH v4] eventdev: flag to identify same destined packets enqu= eue >=20 > This patch introduces a `flag` in the Eth TX adapter enqueue API. > Some drivers may support burst functionality only with the packets having > same destination device and queue. >=20 > The flag `RTE_EVENT_ETH_TX_ADAPTER_ENQUEUE_SAME_DEST` can be used > to indicate this so the underlying driver, for drivers to utilize burst f= unctionality > appropriately. >=20 > Signed-off-by: Nipun Gupta > Acked-by: Jerin Jacob > --- >=20 > Changes in v4: > - Update rel note specifying the API change > - Remove redundant rte_event_tx_adapter_enqueue_same_dest API >=20 > /** > * Enqueue a burst of events objects or an event object supplied in *rte= _event* > * structure on an event device designated by its *dev_id* through the = event > @@ -324,6 +329,10 @@ rte_event_eth_tx_adapter_event_port_get(uint8_t > id, uint8_t *event_port_id); > * The number of event objects to enqueue, typically number of > * rte_event_port_attr_get(...RTE_EVENT_PORT_ATTR_ENQ_DEPTH...) > * available for this port. > + * @param flags > + * RTE_EVENT_ETH_TX_ADAPTER_ENQUEUE_ flags. > + * #RTE_EVENT_ETH_TX_ADAPTER_ENQUEUE_SAME_DEST signifies that all > the > + packets > + * which are enqueued are destined for the same Ethernet port & Tx queu= e. > * > * @return > * The number of event objects actually enqueued on the event device. = The > @@ -343,7 +352,8 @@ static inline uint16_t > rte_event_eth_tx_adapter_enqueue(uint8_t dev_id, > uint8_t port_id, > struct rte_event ev[], > - uint16_t nb_events) > + uint16_t nb_events, > + const uint8_t flags) > { > const struct rte_eventdev *dev =3D &rte_eventdevs[dev_id]; >=20 > @@ -359,7 +369,12 @@ rte_event_eth_tx_adapter_enqueue(uint8_t dev_id, > return 0; > } > #endif > - return dev->txa_enqueue(dev->data->ports[port_id], ev, nb_events); > + if (flags) > + return dev->txa_enqueue_same_dest(dev->data- > >ports[port_id], > + ev, nb_events); > + else > + return dev->txa_enqueue(dev->data->ports[port_id], ev, > + nb_events); > } For the if (flags) condition to work for the PMDs that support RTE_EVENT_ET= H_TX_ADAPTER_CAP_INTERNAL_PORT but do not have a txa_enqueue_same_dest call= back, doesn't the dev->txa_enqueue_same_dest pointer need to be set to the = same value as dev->txa_enqueue ? Thanks, Nikhil