From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91250A0528; Mon, 20 Jan 2020 10:55:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C16582F4F; Mon, 20 Jan 2020 10:55:16 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7E8AF2C6A; Mon, 20 Jan 2020 10:55:14 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Jan 2020 01:55:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,341,1574150400"; d="scan'208";a="374278169" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga004.jf.intel.com with ESMTP; 20 Jan 2020 01:55:13 -0800 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 20 Jan 2020 01:55:13 -0800 Received: from orsmsx110.amr.corp.intel.com ([169.254.10.111]) by ORSMSX158.amr.corp.intel.com ([169.254.10.113]) with mapi id 14.03.0439.000; Mon, 20 Jan 2020 01:55:12 -0800 From: "Rao, Nikhil" To: Thomas Monjalon , "dev@dpdk.org" CC: "stable@dpdk.org" , Chas Williams , "Richardson, Bruce" , Stephen Hemminger , "Pattan, Reshma" Thread-Topic: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is disabled Thread-Index: AQHVuV2kYLUQFoKgTUqZQvZYG5YlfqfzODMAgABDzrA= Date: Mon, 20 Jan 2020 09:55:11 +0000 Message-ID: <1F668163772FA946975B9466A9DFF729EF2F0AEF@ORSMSX110.amr.corp.intel.com> References: <20191218115831.4035-1-reshma.pattan@intel.com> <20191223065305.18434-1-reshma.pattan@intel.com> <4605926.oAaWjsssbx@xps> In-Reply-To: <4605926.oAaWjsssbx@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, January 20, 2020 3:20 AM > To: dev@dpdk.org > Cc: stable@dpdk.org; Rao, Nikhil ; Chas Williams > ; Richardson, Bruce ; > Stephen Hemminger ; Pattan, Reshma > > Subject: Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is > disabled >=20 > Someone to review please? >=20 > 23/12/2019 07:53, Reshma Pattan: > > Some unit tests has dependency on RING PMD, so this patch is trying to > > fix those and other closely related issues. > > > > 1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter unit > > tests are dependent on ring PMD, so compile those tests only when ring > > PMD is enabled else ignore. > > > > 2)get rid of make file error which was added by bond unit test for > > ring PMD disabled case which is not necessary. > > > > 3)Tx adapter UT is dependent on RING PMD, but it was observed that it > > was missing from the run in meson build, so added it. TX adapter UT > > uses 'sw event and 'null' pmd drivers, so for shared builds the > > drivers .so path has to be passed to the test args of meson UT run. > > > > Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library") > > Fixes: fdeb30fa71 ("test/bitrate: add unit tests for bitrate library") > > Fixes: 1e3676a06e ("test/latency: add unit tests for latencystats > > library") > > Fixes: 46cf97e4bb ("eventdev: add test for eth Tx adapter") > > Fixes: d23e09e0ef ("app/test: link with ring pmd when needed") > > > > CC: stable@dpdk.org > > CC: Nikhil Rao > > CC: Chas Williams > > CC: Bruce Richardson > > CC: Stephen Hemminger > > > > Reported-by: Stephen Hemminger > > Signed-off-by: Reshma Pattan > > --- > > v5: remove extra blank line. > > v4: fix event_eth_tx_adapter_autotest for shared build as reported by > > travis-ci > > https://travis-ci.com/ovsrobot/dpdk/jobs/249598391 > > v3: add missing test event_eth_tx_adapter_autotest. > > Add link bonding mode4 test to drivers test. > > v2: fix comments of v1 and combine the patches 1/2 and 2/2 of v1 > > --- > > app/test/Makefile | 16 +++++----------- > > app/test/meson.build | 36 ++++++++++++++++++++++-------------- > > app/test/process.h | 8 ++++++++ > > app/test/test.c | 2 ++ > > 4 files changed, 37 insertions(+), 25 deletions(-) >=20 >=20 >=20 For the fixes related to event_eth_tx_adapter_autotest Tested-by: Nikhil Rao