From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F9D2A04C0; Fri, 25 Sep 2020 11:41:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BEE071D52F; Fri, 25 Sep 2020 11:41:53 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 57E3E1D14C for ; Fri, 25 Sep 2020 11:41:52 +0200 (CEST) IronPort-SDR: L8PQQypD4VD3Tq40rzPIlqCyoUN5QJ+8wliMTw2buMC8iEhltquqESVfMcjCr0LvsoR/as8AKl AWgBpOtCH14w== X-IronPort-AV: E=McAfee;i="6000,8403,9754"; a="246265388" X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="246265388" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 02:41:51 -0700 IronPort-SDR: GQBjqpiJETrXtWodPdFbMT8sKROlJfUyA+9tc6dUefSUPE/0FZJ96jcNP9GAtbnw7zt2H2wuOR 74voB9yYp7Fw== X-IronPort-AV: E=Sophos;i="5.77,301,1596524400"; d="scan'208";a="487400750" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.10.211]) ([10.252.10.211]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Sep 2020 02:41:50 -0700 To: "Min Hu (Connor)" , dev@dpdk.org Cc: stephen@networkplumber.org, bruce.richardson@intel.com, jerin.jacob@caviumnetworks.com References: <1599219135-53194-2-git-send-email-humin29@huawei.com> <1600866002-35908-1-git-send-email-humin29@huawei.com> From: Ferruh Yigit Message-ID: <1a04545f-66e4-1497-2aec-7463279b7002@intel.com> Date: Fri, 25 Sep 2020 10:41:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <1600866002-35908-1-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V3 0/4] change data type in TC queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/23/2020 1:59 PM, Min Hu (Connor) wrote: > From: Huisong Li > > This series change data type in TC rxq and TC txq, > fix compiling errors for per-queue statistics. > > Huisong Li (4): > dpdk: fix compiling errors for per-queue statistics > ethdev: change data type in TC rxq and TC txq > doc: announce modified field in DCB TC queue mapping > doc: announce modified in queue_stats_mapping api > The change request from previous version seems not addressed, can you please check: http://inbox.dpdk.org/dev/93479bbe-7ebe-a400-2805-5debd96a0937@intel.com/ Basically it requires following change: diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 4df42dbc28..23e624f442 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -8346,7 +8346,7 @@ cmdline_parse_token_num_t cmd_setqmap_queueid = queue_id, UINT16); cmdline_parse_token_num_t cmd_setqmap_mapvalue = TOKEN_NUM_INITIALIZER(struct cmd_set_qmap_result, - map_value, UINT8); + map_value, UINT16); cmdline_parse_inst_t cmd_set_qmap = { .f = cmd_set_qmap_parsed, Also you can drop deprecation notes as explained here: http://inbox.dpdk.org/dev/38b50f43-0b31-02a8-87ec-d937d83d051a@intel.com/ Thanks, ferruh