From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3627EA0C41; Fri, 29 Oct 2021 19:33:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF18A40688; Fri, 29 Oct 2021 19:33:36 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 85D3340395 for ; Fri, 29 Oct 2021 19:33:34 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10152"; a="230665045" X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="230665045" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2021 10:33:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,193,1631602800"; d="scan'208";a="581103727" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga002.fm.intel.com with ESMTP; 29 Oct 2021 10:33:14 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 29 Oct 2021 10:33:14 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 29 Oct 2021 10:33:14 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 29 Oct 2021 10:33:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5QBOt9GVwXtLhqqE+qTENQL6Fg8b5m/Ms16aXlqXpC3LecQxGfOTb01bnYDTnqcmcu2vnsYEpYgjSPTUXoGtztypZvoJEpJLssdm9tZvzRlJv2S3D+XMHxhpfTaRx5U5cKigqnAFwGs677MdVlfS+GsQ7LhSox9fTsc7J1Y06aDcQ9vZorXitelU+w25IoDPVdjJWtGglLcesNA0hjQ3xeSevo+1nl1+32u3PvYlRNo6TVg4L9qbr9iJ/toXOuhw8bD6eRnMDfWTqexpBb06Oi/n8hZrdJz+YwhYKX9yO7XSx0YSL3j/+cJQBlkPdg4Rn0yJUukjkI6IWs/789bvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kAQGrFmLWzJm1KpkAiCdJNQKfsBRFchnIc21yp7GY5A=; b=PxZvHaDwSKvSCSOVNNdqrQXTWJhPsNooGNXPIukP8RCHoWkqNBVL7AaAZmh01ngufm2PZLiXIcxYD7hUUg7z+GqYaaF27gvJZNKSUqHbMl6zndXXcnnFjd+a32ttEzV7ijfTcHHXBsqkRj3S2+Ygz3opiV+Yq9F2qCTFmqwc1/AN4wecLz7DzU1ywcdrUbZQ62ByF/trYW5Nws7NVWk3MzfKiSyoRHFqcdkRZGrsDuBaqzgKKUAW+KJbpyLX96u/pntdGF3QcNZyZG6Cwk6RpT8UdiB5kIpDky930ej9MvVvNkq+DempwN2QZ/JGZhozqoFFw9HbAW0BHmcEbmBNow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kAQGrFmLWzJm1KpkAiCdJNQKfsBRFchnIc21yp7GY5A=; b=JVvFf0x7OI75F3Mvlo7wdpvDQEQ5MbScvamkvAk7OL585LvX6ZCmyW2eaito/7Mck3eeTEJZN0NFozmNB2BXp8YHPpv1t7FFwww4UTdgb7sHyrWgHPwrPI1m93cdq+v5S6yLBHkrhpQUDQlxsN+s5fl5l/s/BpI3yXXLelwftFY= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4870.namprd11.prod.outlook.com (2603:10b6:510:34::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Fri, 29 Oct 2021 17:33:10 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.015; Fri, 29 Oct 2021 17:33:10 +0000 Message-ID: <1a046964-cb84-0dc1-abb3-e0ecc323ae6d@intel.com> Date: Fri, 29 Oct 2021 18:33:02 +0100 Content-Language: en-US To: Radu Nicolau , Jingjing Wu , Beilei Xing , Ray Kinsella CC: , , , , , References: <20210909142428.750634-1-radu.nicolau@intel.com> <20211028160500.2775783-1-radu.nicolau@intel.com> <20211028160500.2775783-5-radu.nicolau@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211028160500.2775783-5-radu.nicolau@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0801CA0058.eurprd08.prod.outlook.com (2603:10a6:4:2b::26) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0801CA0058.eurprd08.prod.outlook.com (2603:10a6:4:2b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13 via Frontend Transport; Fri, 29 Oct 2021 17:33:08 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ee360e7-32ad-494e-e989-08d99b022d35 X-MS-TrafficTypeDiagnostic: PH0PR11MB4870: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZaEAp7GgK6i1Xv6xWr2HSYBWKd/5BaiktLYyKAIqVEUmchA9WNryJeqca8oSANFaorlWUbUut167Q7nlKTxSdAc+t2luJA1ART2pQO2R8fv0ei4XQTMIoUv/xA6XYza+3Cy7ls/HuiZPdtTW6NaXvunjyv8IKlCyNe53aPOK8kTQbVzO8z0h1JiBB9WXKHHJFqWQOgxElskAgqBE+i8Z+SH7PnPNuxZqAKEgrTLi0kdN9ehKfftkFhBzRjQVbhGfG7Lt1+ojbQRYZCBFL2xRC09t9dCv4UnKAr7LQPnwPUvQMqg2JRDyKFubDdlEKvEt3eLPl9Ycl4rTSlWUSIX/dhzqkbAJIPEHbYwEYV6vjcL/kNf4rsHLcYRSppwyeciss1nYo8LL54CEaRcPtHLtuapINnJSkQlG06NF5NTs3lgK57i7xiHQvYSKK33+FXGonoHF4MaHxAiLmnBDWjiSlexHwBKJrbCkW2TcfRYdprR12tHOFpzN3vL1HzP6vctL28TuCNM9azCSaX+/XYtqFjxwL8Fr6ME5p4FPrZEyPSYIxk1UxY2R/6HEaOSdpL39eVRtwX3lpLp14w1VQh1XqWdnUjb2/qfisPI2/3UbhbuTkHq98wOAnclRW1uj7XpMg+08DD3h6V1VxnwGyGl/V2RDm/6X4Xu0txaNlVJfD5ACiDFPurhfWWQPBHnIEp7ngo6ToKJ5BvN6xftivM9Pjw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(110136005)(83380400001)(53546011)(26005)(107886003)(8676002)(31696002)(44832011)(8936002)(186003)(6486002)(956004)(2906002)(316002)(16576012)(36756003)(508600001)(6666004)(66556008)(31686004)(38100700002)(2616005)(82960400001)(66476007)(86362001)(66946007)(5660300002)(4326008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2t1MHArT2dpMlJXQk13SVhZbE1Eby9iZU02WWlOUy9pVDExdGRjczVqR1hO?= =?utf-8?B?ZnRTZVVZK0VjUFhIclZxdFJZbHJ0SWoxYVBKY1NOMzFuZUZxTDc4SDFtbVd1?= =?utf-8?B?YVZtbCtWaHNKNlRtaE1lNDEzWnFLbzVwbllBZkswcWE2ZUdZQXZyTG9oaDdL?= =?utf-8?B?bEdLNFFjWDBoQ1hLTjJYdTQ4NEZ1aVRxSUUzZytmdzdMRUpKcy9RQkpIQVlM?= =?utf-8?B?ZkxCNVNkYU9ScWo4cnhHQ1dLbzRkSHBUbGdRM3dEYUZwKzFhelY0eGx0QmVw?= =?utf-8?B?VE45akRoYXJBRVlaS2diLzFnWTRLbG5vemdoSEhua2JXeURWay9BZ3JrN0Fr?= =?utf-8?B?QllGN3lmbktLRUJ1aFVxZDM0UmFyVmhqL1hKblgvNS9XU29YWXpKUXl4U3Vo?= =?utf-8?B?RFgyczlqM3hoR3pzaEJ6S2RvMGtHRW8rby9NdkdkbVc1L2Rsc1YzcmpBakdM?= =?utf-8?B?KzQ0VWRrcURTT25jdVNhOHZ0T29mNzlVYUpvSGVCOXhLTmF2d0Rqem9KVVo3?= =?utf-8?B?L05GR3pueEozdTM2SEhiME5VK25QTVJnTzJXRjREYXhldlNQcjJTU1JXNEtT?= =?utf-8?B?c295M3F5Sm1YR2R1cEJMSnZDb0pXa2gySDl4Z0tzQkV1T21WS2dCbmFFQ0JE?= =?utf-8?B?OVlVNlpQbjVuY3pSeEEvSENzMWplMTN1K1hJcnFOR08xV1lQRFk3UVZYVE1Q?= =?utf-8?B?UGhzeFQ3emV5Qm9JMTVoV2tmQld1NmNJMHNORDVQeGhCQkMyNXdJWXllZ1l1?= =?utf-8?B?V1FSYWRaUWJtcG00emhTdWpTZTNnQldPRGZnNVdPbmJsd2N3d1VlVUhWMGRI?= =?utf-8?B?TVJDQU1vSHRJdlpHQWlMNzdrdVI1VWkyTzBucjJDMkZmUTBJZFlPVVF4Z2N6?= =?utf-8?B?R2hQT09Db0JBMW5kcWU0S1hNcGk1eWExMnQwU3ZPci9kdTFvdFBDREtkaDlu?= =?utf-8?B?ZVBuczU3R1B6Tmh5dGphVEhYSkFaS2h4K0pUY05MNXZHd3NSR09uZTY3N3JS?= =?utf-8?B?NCs0TXpiajdCSjJEYmVIWGNnNWpicjh5c1E5NWhDdjViMUhpRDFJN2VkWElM?= =?utf-8?B?aGZOeWpXR0dQVTFUckQ1bW8wUmZvRFNtTFBYYTU4d2tUVW9JdlNsaW1ReDZ4?= =?utf-8?B?SVR5WWxsSk1UTjdvUFpISzVkOTR6djlTZG9xM01XZzhNVGJuTEI4ckt2UEk2?= =?utf-8?B?bi95ZTZaRXBIN3dldzZWOXZmUUlWdUp0Y0w4OXFjV1F6YVgyMkZzZlRjRUFs?= =?utf-8?B?QnA5N0RwV3JvbFFJUFZxVnRNazAwSVR5eXo3UnhMS0hIR0owYVh3dDBLeXpn?= =?utf-8?B?S085Q1I0VHZIc3pwdkk4aml4TEZLMkQvcGlUb3FyU2JGZUpEMnkveDZGZm1v?= =?utf-8?B?NHNCVGFZY2xTVis5VUwzYWUraVhyY1ZZR2xueTE5aEpSWnNtMWdQUkxOQlRC?= =?utf-8?B?TkkwS0E0d0pEelVJM1UvQnY5WTFuWitWTWM3T0lJM2RCSkhTeGU4WlVHZUUx?= =?utf-8?B?b0pYdUxDbEZUaytrcXpJcHNaUHlHcFNhOEQ5cnRVbUZ3ZU8zSlF1ejRxWDlJ?= =?utf-8?B?Z1dSMUpueE5Zc2Z5NW5OREd4cVZ6Zko2TGg0U0NHcThrdlhlZGFXaU52ZXhT?= =?utf-8?B?ZThGcDNEdDFERU9qWktDRThuZGpKaW9LRjlQWFRGa09MS1RDMy9uTVFiTStl?= =?utf-8?B?ZUZJR0hFTGdOT1BPa3k4U0NlM2hCdmFmbzhKc3d3OEkyUGtyRFgwTThWNVgy?= =?utf-8?B?c2ZLZlAwZlpDdXE3YktaWDdTQVNXM2RLdHVNdllHdEV3WWE5WmlaN1c3RlBo?= =?utf-8?B?SysvSUZSSFNGNFhtQ2FUeFp0dG9qbjNNbFozSDlRRWdoSkhMeUJFZDhOemlr?= =?utf-8?B?SmQ4eTRIbDB5V3VBYjIwTHRoTDZJdVNpd3VxSzFSMlBHTmJjc2FEK0pXc0VW?= =?utf-8?B?MnRYK3E4MzlTTjdvd3laTE5mYURodUVuclZFdi9YZkpQd1JBT2FMUXNDb0Jj?= =?utf-8?B?ZXRZZ3hDTHhpMTYvR3V6UzdPQjcyOTNwU0ZMZDZyQjROV2lXL2V6RlhMZms0?= =?utf-8?B?dEo2Qmhzb3lJaDNLemhaeGsrTWZRdGxteGQ0eEw1R0EzSUx5eUNJNWFId1FH?= =?utf-8?B?K012WWhEYi96K2V5dTY1ZDRDaFRuYzBWb0FZQzZRMFRFa3FGSlBGbFAxRGJB?= =?utf-8?Q?AzfiDxKnkZxB/3H2PaPrI0Q=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0ee360e7-32ad-494e-e989-08d99b022d35 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2021 17:33:10.3898 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BvBj115FZn1x3eJceRWI7jCEfL9hVaniukXwL/JuUD+nRFPmjCR1RlwQmHiJ9qggUMaqgOLejpoqCXK5GeOj0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4870 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v13 4/7] net/iavf: add iAVF IPsec inline crypto support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/28/2021 5:04 PM, Radu Nicolau wrote: > Add support for inline crypto for IPsec, for ESP transport and > tunnel over IPv4 and IPv6, as well as supporting the offload for > ESP over UDP, and inconjunction with TSO for UDP and TCP flows. > Implement support for rte_security packet metadata > > Add definition for IPsec descriptors, extend support for offload > in data and context descriptor to support > > Add support to virtual channel mailbox for IPsec Crypto request > operations. IPsec Crypto requests receive an initial acknowledgment > from phsyical function driver of receipt of request and then an > asynchronous response with success/failure of request including any > response data. > > Add enhanced descriptor debugging > > Refactor of scalar tx burst function to support integration of offload > > Signed-off-by: Declan Doherty > Signed-off-by: Abhijit Sinha > Signed-off-by: Radu Nicolau > Reviewed-by: Jingjing Wu <...> > @@ -973,6 +984,11 @@ iavf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) > if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_CRC) > dev_info->rx_offload_capa |= RTE_ETH_RX_OFFLOAD_KEEP_CRC; > > + if (iavf_ipsec_crypto_supported(adapter)) { > + dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_SECURITY; > + dev_info->tx_offload_capa |= DEV_TX_OFFLOAD_SECURITY; Should use new macors with RTE_ prefix <...> > @@ -36,10 +37,10 @@ > RTE_ETH_TX_OFFLOAD_TCP_CKSUM) > > #define IAVF_RX_VECTOR_OFFLOAD ( \ > - RTE_ETH_RX_OFFLOAD_CHECKSUM | \ > - RTE_ETH_RX_OFFLOAD_SCTP_CKSUM | \ > - RTE_ETH_RX_OFFLOAD_VLAN | \ > - RTE_ETH_RX_OFFLOAD_RSS_HASH) > + DEV_RX_OFFLOAD_CHECKSUM | \ > + DEV_RX_OFFLOAD_SCTP_CKSUM | \ > + DEV_RX_OFFLOAD_VLAN | \ > + DEV_RX_OFFLOAD_RSS_HASH) And should keep the RTE_ prefix version of the macros. Updating both above two in next-net.