DPDK patches and discussions
 help / color / mirror / Atom feed
From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Subject: RE: [PATCH v2 2/6] ipsec: replace unnecessary comma operator
Date: Fri, 15 Aug 2025 13:47:37 +0000	[thread overview]
Message-ID: <1a3329ad3a164b7dbf838bf11698fa42@huawei.com> (raw)
In-Reply-To: <20250814212901.88863-3-stephen@networkplumber.org>



> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, August 14, 2025 10:29 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Konstantin Ananyev <konstantin.ananyev@huawei.com>; Vladimir
> Medvedkin <vladimir.medvedkin@intel.com>
> Subject: [PATCH v2 2/6] ipsec: replace unnecessary comma operator
> 
> Use of comma as statement separator is discouraged and
> reported as warning by clang with -Wcomma
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/ipsec/misc.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/ipsec/misc.h b/lib/ipsec/misc.h
> index fd4d3f5256..54dc5c2d4d 100644
> --- a/lib/ipsec/misc.h
> +++ b/lib/ipsec/misc.h
> @@ -126,7 +126,8 @@ cpu_crypto_bulk(const struct rte_ipsec_session *ss,
> 
>  	const uint32_t vnum = RTE_DIM(vec);
> 
> -	j = 0, n = 0;
> +	j = 0;
> +	n = 0;
>  	vofs = 0;
>  	for (i = 0; i != num; i++) {
> 
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com> 

> 2.47.2


  reply	other threads:[~2025-08-15 13:47 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 23:26 [RFC 0/7] avoid unnecessary use of comma op Stephen Hemminger
2025-03-12 23:26 ` [RFC 1/7] eal: replace unnecessary comma operator Stephen Hemminger
2025-03-12 23:26 ` [RFC 2/7] ipsec: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 3/7] graph: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 4/7] net/mlx4: replace unnecessary comma operators Stephen Hemminger
2025-03-12 23:27 ` [RFC 5/7] net/mlx5: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 6/7] test: " Stephen Hemminger
2025-03-12 23:27 ` [RFC 7/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28 ` [PATCH v2 0/6] Enable warnings about use of comma operator Stephen Hemminger
2025-08-14 21:28   ` [PATCH v2 1/6] eal: replace unnecessary " Stephen Hemminger
2025-08-15 13:48     ` Konstantin Ananyev
2025-08-14 21:28   ` [PATCH v2 2/6] ipsec: " Stephen Hemminger
2025-08-15 13:47     ` Konstantin Ananyev [this message]
2025-08-14 21:28   ` [PATCH v2 3/6] graph: " Stephen Hemminger
2025-08-15 13:49     ` Konstantin Ananyev
2025-08-14 21:28   ` [PATCH v2 4/6] test: replace unnecessary comma operators Stephen Hemminger
2025-08-15 13:50     ` Konstantin Ananyev
2025-08-14 21:28   ` [PATCH v2 5/6] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-14 21:28   ` [PATCH v2 6/6] config: enable comma warnings Stephen Hemminger
2025-08-15 14:00     ` Konstantin Ananyev
2025-08-15  0:30   ` [PATCH v2 0/6] Enable warnings about use of comma operator fengchengwen
2025-08-15  6:40   ` Morten Brørup
2025-08-15 16:15     ` Stephen Hemminger
2025-08-15 16:26 ` [PATCH v3 0/7] avoid unnecessary " Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 1/7] eal: replace unnecessary " Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 2/7] ipsec: " Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 3/7] graph: " Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 4/7] test: replace unnecessary comma operators Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 5/7] app/testpmd: replace comma operator with bracket Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 6/7] examples: remove unnecessary use of comma operator Stephen Hemminger
2025-08-15 16:26   ` [PATCH v3 7/7] config: enable comma warnings Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a3329ad3a164b7dbf838bf11698fa42@huawei.com \
    --to=konstantin.ananyev@huawei.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).