From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 0CA682B9E for ; Tue, 28 Nov 2017 11:48:40 +0100 (CET) Received: from pure.maildistiller.com (unknown [10.110.50.29]) by dispatch1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTP id 84C3C20164; Tue, 28 Nov 2017 10:48:39 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us4.ppe-hosted.com (unknown [10.110.49.251]) by pure.maildistiller.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 0661510004F; Tue, 28 Nov 2017 10:48:39 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id BB079B4006A; Tue, 28 Nov 2017 10:48:38 +0000 (UTC) Received: from [192.168.239.128] (193.34.186.16) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 28 Nov 2017 10:48:34 +0000 To: Ferruh Yigit , CC: Mark Spender References: <1510819481-6809-1-git-send-email-arybchenko@solarflare.com> <1510819481-6809-30-git-send-email-arybchenko@solarflare.com> <25261881-7716-710f-354e-0655c5c48eaa@intel.com> From: Andrew Rybchenko Message-ID: <1a5d7a57-25c5-bdda-5b8c-7164e7ecd3a3@solarflare.com> Date: Tue, 28 Nov 2017 13:48:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <25261881-7716-710f-354e-0655c5c48eaa@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [193.34.186.16] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23496.003 X-TM-AS-Result: No--8.364500-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1511866119-nUr9z91ipKQ4 Subject: Re: [dpdk-dev] [PATCH 29/53] net/sfc/base: request info about outer frame in Rx events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 10:48:40 -0000 On 11/27/2017 10:57 PM, Ferruh Yigit wrote: > On 11/16/2017 12:04 AM, Andrew Rybchenko wrote: >> From: Mark Spender >> >> For encapsulated packets, the firmware gives info about the inner frame >> fields by default. When not using encapsulation offload, ask for info >> about the outer frame instead. >> >> Unless bug69842 is fixed, a driver reload will be needed, at least > I guess this is your internal bug tracking id, this is not very useful in commit > log since we don't have access to it. > > Leaving it as it is, but it would be more useful to describe defect here instead > of referring to its id. > Let's rephrase the paragraph in the following way: On SFN8xxx with firmware version before v6.4.2.1007 driver reload is needed after switching from full-feature to low-latency firmware variant since the driver still thinks that firmware supports encapsulation, but firmware does not tolerate request to provide info about outer frame in Rx events. >> on some platforms, when switching from full-featured to low-latency >> firmware (though users are unlikely to hit that). >> >> Signed-off-by: Mark Spender >> Signed-off-by: Andrew Rybchenko > <...> >