From: "Hunt, David" <david.hunt@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] l3fwd-power: add Rx interrupt timeout
Date: Thu, 30 Apr 2020 14:08:24 +0100 [thread overview]
Message-ID: <1a5fd728-c50a-b30b-88ff-f3985324beb6@intel.com> (raw)
In-Reply-To: <f98eb89eb043810e5b4c523a51408a2c053cf490.1588243784.git.anatoly.burakov@intel.com>
On 30/4/2020 11:49 AM, Anatoly Burakov wrote:
> Currently, thread waiting on an interrupt does not have a timeout, so
> it will not ever wake up until traffic arrives. This means that, when
> time comes to exit the application, it will not quit unless there
> happens to be traffic coming in and waking up the thread from sleep.
>
> Fix it so that the interrupt thread sleeps for 10ms before waking up
> and attempting to poll again. Additionally, remove the log message
> to avoid spamming about entering interrupt mode.
>
> Fixes: 613ce6691c0d ("examples/l3fwd-power: implement proper shutdown")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
Acked-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2020-04-30 13:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 12:21 [dpdk-dev] [PATCH] " Anatoly Burakov
2020-04-29 12:27 ` Hunt, David
2020-04-30 10:49 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2020-04-30 13:08 ` Hunt, David [this message]
2020-05-07 10:46 ` [dpdk-dev] [PATCH v3] " Anatoly Burakov
2020-05-08 1:50 ` Ma, LihongX
2020-05-11 19:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a5fd728-c50a-b30b-88ff-f3985324beb6@intel.com \
--to=david.hunt@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).