From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B219FA00C5; Thu, 30 Apr 2020 15:08:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F4DB1DBC6; Thu, 30 Apr 2020 15:08:31 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 578731DBBE; Thu, 30 Apr 2020 15:08:29 +0200 (CEST) IronPort-SDR: z/bL5ykplQxlnrO7MCwWbTPQwAqq7/XdIzIBWE4dewGlgeGvdlaMnZvJwbyNWFDoIYJWcbvIUm R27DrM32WWaw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 06:08:28 -0700 IronPort-SDR: P/rTuIjCeyefz+J1prcv3vFwU/l/3b98IE/k/L9/EsIUHq5TpfOehrlKenQ46WG2eDuc0npA9b sNdx2nk/8lcA== X-IronPort-AV: E=Sophos;i="5.73,334,1583222400"; d="scan'208";a="459569409" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.213.42]) ([10.213.213.42]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 06:08:26 -0700 To: Anatoly Burakov , dev@dpdk.org Cc: stable@dpdk.org References: <0ebd62205da8cd9964dcd370a69cc5a38f54dede.1588162894.git.anatoly.burakov@intel.com> From: "Hunt, David" Message-ID: <1a5fd728-c50a-b30b-88ff-f3985324beb6@intel.com> Date: Thu, 30 Apr 2020 14:08:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2] l3fwd-power: add Rx interrupt timeout X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 30/4/2020 11:49 AM, Anatoly Burakov wrote: > Currently, thread waiting on an interrupt does not have a timeout, so > it will not ever wake up until traffic arrives. This means that, when > time comes to exit the application, it will not quit unless there > happens to be traffic coming in and waking up the thread from sleep. > > Fix it so that the interrupt thread sleeps for 10ms before waking up > and attempting to poll again. Additionally, remove the log message > to avoid spamming about entering interrupt mode. > > Fixes: 613ce6691c0d ("examples/l3fwd-power: implement proper shutdown") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov > --- Acked-by: David Hunt