Hi Stephen,

Thank you for the review.

I will fix the documentation to match the features implemented in the code.

To clarify, the nbl driver does support all the features listed in the documentation.
There was a misunderstanding on my part about the submission process - I thought we were supposed to submit basic functionality first,
and then add features like TSO, checksum offload, and FEC in subsequent patches after the initial driver merge.

Thank you.


------------------------------------------------------------------
发件人：Stephen Hemminger <stephen@networkplumber.org>
发送时间：2025年10月21日(周二) 22:21
收件人：Dimon<dimon.zhao@nebula-matrix.com>
抄　送：dev<dev@dpdk.org>; Thomas Monjalon<thomas@monjalon.net>; Kyo Liu<kyo.liu@nebula-matrix.com>; Leon<leon.yu@nebula-matrix.com>; Sam<sam.chen@nebula-matrix.com>
主　题：Re: [PATCH v13 01/17] net/nbl: add doc and minimum nbl build framework

As part of driver review I audit the documentation in features
against what is actually implemented. Many new drivers seem to cut and paste
from existing drivers and not implement features.

> diff --git a/doc/guides/nics/features/nbl.ini b/doc/guides/nics/features/nbl.ini
> new file mode 100644
> index 0000000000..90ec593759
> --- /dev/null
> +++ b/doc/guides/nics/features/nbl.ini
> @@ -0,0 +1,31 @@
> +;
> +; Supported features of the 'nbl' network poll mode driver.
> +;
> +; Refer to default.ini for the full list of available PMD features.
> +;
> +[Features]
> +Speed capabilities   = Y
> +Link speed configuration = Y
> +Link status          = Y
> +FEC                  = Y

There is no ethdev ops for fec_get in this driver.
It doesn't support FEC

> +Queue start/stop     = Y

There is no operation for tx_queue_start or rx_queue_start

> +Burst mode info      = Y

Driver has prototype for txrx_burst_mode_get but no implementation
or ethdev_ops.

> +MTU update           = Y
> +Scattered Rx         = Y
> +TSO                  = Y
> +Promiscuous mode     = Y
> +Allmulticast mode    = Y
> +Unicast MAC filter   = Y
> +RSS reta update      = Y
> +VLAN filter          = Y

No ethdev_ops for vlan_filter_set

> +VLAN offload         = P

Driver does not report RTE_ETH_VLAN_STRIP_OFFLOAS

> +L3 checksum offload  = P
> +L4 checksum offload  = P

Driver does not report RTE_ETH_RX_OFFLOAD_TCP_CKSUM etc.

> +Basic stats          = Y
> +Extended stats       = Y
> +Stats per queue      = Y
> +FW version           = Y

Not implemented.

> +Module EEPROM dump   = Y

Not implemented.

> +Linux                = Y
> +ARMv8                = Y
> +x86-64               = Y

Please fix the documentation and/or code to match features
and resubmit

本邮件所含信息及其任何附件为保密信息且可能属于专有信息。任何非指定接收人均无权访问本邮件。如果您不是该邮件的指定接收人，那么任何对本邮件内容进行披露，复制或使用的行为均是禁止的。如果您不是该邮件的指定接收人，请您立即通过邮件通知 compliance@nebula-matrix.com并立即删除您错误接受的邮件。
The information in this message and any attachments is confidential and may be privileged.  Access to this email by anyone other than the intended recipient is not authorized.  If you are not the intended recipient, disclosure, copying or use of the contents of this email is prohibited.  If you are not the intended recipient, please notify  compliance@nebula-matrix.com immediately by email, and please destroy the email you received in error.