From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "mdr@ashroe.eu" <mdr@ashroe.eu>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"grive@u256.net" <grive@u256.net>
Subject: Re: [dpdk-dev] [PATCH 0/5] kvargs: promote or remove experimental api
Date: Sat, 25 Sep 2021 07:02:26 +0000 [thread overview]
Message-ID: <1a77cfc18a3dd6207e09efdc6f5e3b4820eff4f1.camel@nvidia.com> (raw)
In-Reply-To: <20210924155740.20510-1-olivier.matz@6wind.com>
On Fri, 2021-09-24 at 17:57 +0200, Olivier Matz wrote:
> This patchset promotes 2 functions rte_kvargs_parse_delim() and
> rte_kvargs_get() as stable.
>
> It also replaces rte_kvargs_strcmp() by a new one
> rte_kvargs_get_with_value(), which is easier to use.
>
> Olivier Matz (5):
> kvargs: promote delimited parsing as stable
> kvargs: promote get from key as stable
> kvargs: new function to get from key and value
> kvargs: remove experimental function to compare string
> kvargs: fix comments style
>
> drivers/bus/auxiliary/auxiliary_params.c | 9 ++--
> drivers/bus/vdev/vdev_params.c | 13 +-----
> lib/kvargs/rte_kvargs.c | 32 +++++++------
> lib/kvargs/rte_kvargs.h | 59 ++++++++++++------------
> lib/kvargs/version.map | 7 +--
> 5 files changed, 57 insertions(+), 63 deletions(-)
>
The whole series looks good to me, the new function that match key and
value directly looks more efficient, thanks!
Reviewed-by: Xueming Li <xuemingl@nvidia.com>
next prev parent reply other threads:[~2021-09-25 7:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 15:57 Olivier Matz
2021-09-24 15:57 ` [dpdk-dev] [PATCH 1/5] kvargs: promote delimited parsing as stable Olivier Matz
2021-09-24 15:57 ` [dpdk-dev] [PATCH 2/5] kvargs: promote get from key " Olivier Matz
2021-09-24 15:57 ` [dpdk-dev] [PATCH 3/5] kvargs: new function to get from key and value Olivier Matz
2021-09-24 15:57 ` [dpdk-dev] [PATCH 4/5] kvargs: remove experimental function to compare string Olivier Matz
2021-09-26 16:30 ` Olivier Matz
2021-09-24 15:57 ` [dpdk-dev] [PATCH 5/5] kvargs: fix comments style Olivier Matz
2021-09-25 7:02 ` Xueming(Steven) Li [this message]
2021-09-29 21:39 ` [dpdk-dev] [PATCH v2 0/5] kvargs: promote or remove experimental api Olivier Matz
2021-09-29 21:39 ` [dpdk-dev] [PATCH v2 1/5] kvargs: promote delimited parsing as stable Olivier Matz
2021-09-29 21:39 ` [dpdk-dev] [PATCH v2 2/5] kvargs: promote get from key " Olivier Matz
2021-09-29 21:39 ` [dpdk-dev] [PATCH v2 3/5] kvargs: new function to get from key and value Olivier Matz
2021-09-29 21:39 ` [dpdk-dev] [PATCH v2 4/5] kvargs: remove experimental function to compare string Olivier Matz
2021-09-30 14:00 ` Olivier Matz
2021-09-30 15:19 ` David Marchand
2021-09-29 21:39 ` [dpdk-dev] [PATCH v2 5/5] kvargs: fix comments style Olivier Matz
2021-09-30 8:25 ` [dpdk-dev] [PATCH v2 0/5] kvargs: promote or remove experimental api David Marchand
2021-09-30 9:57 ` Kinsella, Ray
2021-09-30 16:19 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a77cfc18a3dd6207e09efdc6f5e3b4820eff4f1.camel@nvidia.com \
--to=xuemingl@nvidia.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=mdr@ashroe.eu \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).