From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 914022B9B
 for <dev@dpdk.org>; Tue, 30 Aug 2016 10:56:22 +0200 (CEST)
Received: from lfbn-1-8252-96.w81-254.abo.wanadoo.fr ([81.254.151.96]
 helo=[192.168.1.13])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84_2) (envelope-from <olivier.matz@6wind.com>)
 id 1beesy-0004m9-UT; Tue, 30 Aug 2016 10:59:14 +0200
To: Matej Vido <vido@cesnet.cz>
References: <1472217646-26219-1-git-send-email-olivier.matz@6wind.com>
 <8dfb056d-7b71-4fae-72c5-ef47383619a2@cesnet.cz>
Cc: dev@dpdk.org, nhorman@tuxdriver.com, thomas.monjalon@6wind.com
From: Olivier Matz <olivier.matz@6wind.com>
Message-ID: <1a95f794-a7c4-1f85-1aad-896e46ab137c@6wind.com>
Date: Tue, 30 Aug 2016 10:56:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.2.0
MIME-Version: 1.0
In-Reply-To: <8dfb056d-7b71-4fae-72c5-ef47383619a2@cesnet.cz>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [RFC] drivers: advertise kmod dependencies in pmdinfo
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Aug 2016 08:56:22 -0000

Hi Matej,

On 08/30/2016 10:40 AM, Matej Vido wrote:
> On 26.08.2016 15:20, Olivier Matz wrote:
> 
>> Add a new macro DRIVER_REGISTER_KMOD_DEP() that allows a driver to
>> declare the list of kernel modules required to run properly.
>>
>> Today, most PCI drivers require uio/vfio.
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>> ---
> [..]
>>  
>> diff --git a/drivers/net/szedata2/rte_eth_szedata2.c
>> b/drivers/net/szedata2/rte_eth_szedata2.c
>> index 483d789..409e71f 100644
>> --- a/drivers/net/szedata2/rte_eth_szedata2.c
>> +++ b/drivers/net/szedata2/rte_eth_szedata2.c
>> @@ -1602,3 +1602,5 @@ static struct rte_driver rte_szedata2_driver = {
>>     PMD_REGISTER_DRIVER(rte_szedata2_driver, RTE_SZEDATA2_DRIVER_NAME);
>>   DRIVER_REGISTER_PCI_TABLE(RTE_SZEDATA2_DRIVER_NAME,
>> rte_szedata2_pci_id_table);
>> +DRIVER_REGISTER_KMOD_DEP(RTE_SZEDATA2_DRIVER_NAME,
>> +    "uio,igb_uio:uio,uio_pci_generic:vfio,vfio-pci");
> Hi Olivier,
> 
> szedata2 doesn't require uio/vfio modules. Instead the following lines
> could be used:
> 
> +DRIVER_REGISTER_KMOD_DEP(RTE_SZEDATA2_DRIVER_NAME,
> +    "combo6core,combov3,szedata2,szedata2_cv3");
> 

ok, I will update it for next revision, thanks !

Olivier