From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 35BA7A0540;
Mon, 13 Jul 2020 14:16:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id D1C261D69E;
Mon, 13 Jul 2020 14:16:06 +0200 (CEST)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
by dpdk.org (Postfix) with ESMTP id 433641D66F
for <dev@dpdk.org>; Mon, 13 Jul 2020 14:16:02 +0200 (CEST)
IronPort-SDR: o3NRJM7B3KANLz85f4ryr8puNAV1SdxPQQzTqSsG68couK95hK0Qg1BjyJTTi5dXJF/fYMY42B
N13v35pUW8zw==
X-IronPort-AV: E=McAfee;i="6000,8403,9680"; a="136766089"
X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="136766089"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
13 Jul 2020 05:16:02 -0700
IronPort-SDR: QsBsnfx0sVqmc9MLtsq4JDwKiaRrNgdS1VG0Nn+jRmRA/IzctmS24Mt1MLH2Uug/zyKaOU6nbI
6VBwt1frPtnw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.75,347,1589266800"; d="scan'208";a="459271816"
Received: from silpixa00399498.ir.intel.com (HELO
silpixa00399498.ger.corp.intel.com) ([10.237.222.52])
by orsmga005.jf.intel.com with ESMTP; 13 Jul 2020 05:16:01 -0700
From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: David Hunt <david.hunt@intel.com>,
reshma.pattan@intel.com
Date: Mon, 13 Jul 2020 13:15:59 +0100
Message-Id: <1ab5d183405f1e1525799310eb1d38a3c88b7009.1594642553.git.anatoly.burakov@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <c568269db57a81ab8fecac06f81c1054f6439100.1594642553.git.anatoly.burakov@intel.com>
References: <c568269db57a81ab8fecac06f81c1054f6439100.1594642553.git.anatoly.burakov@intel.com>
In-Reply-To: <c568269db57a81ab8fecac06f81c1054f6439100.1594642553.git.anatoly.burakov@intel.com>
References: <c568269db57a81ab8fecac06f81c1054f6439100.1594642553.git.anatoly.burakov@intel.com>
Subject: [dpdk-dev] [PATCH 2/2] l3fwd-power: fix updating performance lcore
parameters
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
When perf-config option is specified, we are calling into the power
library even though it may not necessarily be enabled. It is
questionable whether perf-config option is even applicable to non-power
library modes, but for now, fix it just by avoiding calling into the
power library if it wasn't initialized, and assume that every lcore is
high performance core.
Fixes: e0194feb322c ("examples/l3fwd-power: add interrupt-only mode")
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
examples/l3fwd-power/perf_core.c | 27 +++++++++++++++++++--------
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/examples/l3fwd-power/perf_core.c b/examples/l3fwd-power/perf_core.c
index 0a294dfcc8..4705967ea2 100644
--- a/examples/l3fwd-power/perf_core.c
+++ b/examples/l3fwd-power/perf_core.c
@@ -28,12 +28,27 @@ struct perf_lcore_params {
static struct perf_lcore_params prf_lc_prms[MAX_LCORE_PARAMS];
static uint16_t nb_prf_lc_prms;
+static int
+is_hp_core(unsigned int lcore)
+{
+ struct rte_power_core_capabilities caps;
+ int ret;
+
+ /* do we have power management enabled? */
+ if (rte_power_get_env() == PM_ENV_NOT_SET) {
+ /* there's no power management, so just mark it as high perf */
+ return 1;
+ }
+ ret = rte_power_get_capabilities(lcore, &caps);
+ return ret == 0 && caps.turbo;
+}
+
int
update_lcore_params(void)
{
uint8_t non_perf_lcores[RTE_MAX_LCORE];
uint16_t nb_non_perf_lcores = 0;
- int i, j, ret;
+ int i, j;
/* if perf-config option was not used do nothing */
if (nb_prf_lc_prms == 0)
@@ -42,13 +57,9 @@ update_lcore_params(void)
/* if high-perf-cores option was not used query every available core */
if (nb_hp_lcores == 0) {
for (i = 0; i < RTE_MAX_LCORE; i++) {
- if (rte_lcore_is_enabled(i)) {
- struct rte_power_core_capabilities caps;
- ret = rte_power_get_capabilities(i, &caps);
- if (ret == 0 && caps.turbo) {
- hp_lcores[nb_hp_lcores] = i;
- nb_hp_lcores++;
- }
+ if (rte_lcore_is_enabled(i) && is_hp_core(i)) {
+ hp_lcores[nb_hp_lcores] = i;
+ nb_hp_lcores++;
}
}
}
--
2.17.1