From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ECEA45CCB; Mon, 11 Nov 2024 18:46:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08BA0400D6; Mon, 11 Nov 2024 18:46:42 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 5A9A140041; Mon, 11 Nov 2024 18:46:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731347201; x=1762883201; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=tHiUak2ntVkL57blNxSkeJY7Z//fjzIv1nR9xZ0IsxU=; b=oKOlqDf0+MvJ4sy36J2HEu73FBC+GsNDyutjcAOIiZX/Y4dURRkuFWrf wM2wlu832HQYq1txw3uiqVBr5adRtOdxgZCKxtIBFGb8nHLJ29bamJXaC bvo80X3O75NUYEuLZ+juRzHFNMFalwLPdLdS4wiaTDLEsRhEPwRRiOaXM FA/6k9I6g2wa4wYuTG4MrG3aLbDSqJMUlUjFeiTVnXEFKvXJ1QcSKIwbH SvzL9XTJ+e1Ln54ZntOEX/FkbWNZ3a//ogZZfrwQYB8lj9+vw/CVg/8Y9 nAcY00hWqlf1YO3xi6iC8NRcs7c8WUqEdnZFyoNDX23nQMOsw2mot0U+E w==; X-CSE-ConnectionGUID: tyyHeMlcQICfhQT1uXG5Kw== X-CSE-MsgGUID: WYpR63AcSP+9BS0QcL+qxw== X-IronPort-AV: E=McAfee;i="6700,10204,11222"; a="34850794" X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="34850794" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2024 09:46:40 -0800 X-CSE-ConnectionGUID: jxNyL8dsQaG91pI6Jl2ocw== X-CSE-MsgGUID: OhcDdE12Q9q3UHLDZsqxww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,145,1728975600"; d="scan'208";a="117829414" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Nov 2024 09:46:39 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 11 Nov 2024 09:46:38 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 11 Nov 2024 09:46:38 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 11 Nov 2024 09:46:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q/OY3a8GgkBoRcTxrPDLhzrllA7Wrs6WNTdP2FJJKrQYWfeaCMQluPgvPk1MMnvPJCI32V1WAM+RZI1mGLJ83GIkGjb6/TIIjYj3hZYwfILL6i7I22JnwBWTi3ca9oOJFSTKvB3R7cBh2iSC6bz4vAJ2TsW3hU/ORjdibhguy5yJQmNX7Eun17TvWOjmYMDfnC5oeskA0eFpQ831tcYGrWDuhj1BKwRmSd/W8zoXmA4R8mLaEGIY3QxwJmx45o9jzhOcJLZc1L7H5MhVapNkMSX3ncrREaB0eWYf6zh6cLBLXaRL81QAIsWbmEF/rahP4Yxv4F+BqwTqQtSrJ//RkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZeWcq+tZNNQxpDi9HOSQszRlmz2Ejdraq3JSi60k2/Y=; b=h5fLvC61QYcbooOIx6qQGM7A1BIbxK5JAYuZNv4vz71hNN1rAduL0dz0NnjONcE6N1H+3heIZFgRw3fbWt9D6p1YuWkVbApBP07MjnRVFMDSdrv1N947xXAMBCn3JQC+SW4J8NYCBJPTdevcQrSslEP1kSgf/zcsbzR0l0CqhJ+Na/Paxnx4f9slHuIJlbZwe2qOCh0TvyRRxGurN4qWUZhRkzjTecMtbbhVfiodn3aZuf8WnArr8XjwxxPsYm1AjxAMzLHdgZ+rG7KlT6Qy4leCUYNPDysgL0vmLf1gCHRhsG+HQ/wFI86JzNLwnzOjtMSCSqfpmD4fUZdmONNyPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) by CH3PR11MB7390.namprd11.prod.outlook.com (2603:10b6:610:14e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.29; Mon, 11 Nov 2024 17:46:34 +0000 Received: from SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::5851:319:3da6:850b]) by SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::5851:319:3da6:850b%3]) with mapi id 15.20.8137.027; Mon, 11 Nov 2024 17:46:33 +0000 Message-ID: <1acab313-ba0a-4934-8183-624ab8a1cb07@intel.com> Date: Mon, 11 Nov 2024 17:46:29 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/iavf: add segment-length check to Tx prep To: Bruce Richardson , CC: , Padraig Connolly , "Ian Stokes" , Qi Zhang , Kevin Liu References: <20241111164221.3031276-1-bruce.richardson@intel.com> Content-Language: en-US From: "Medvedkin, Vladimir" In-Reply-To: <20241111164221.3031276-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0048.eurprd01.prod.exchangelabs.com (2603:10a6:10:469::17) To SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB5772:EE_|CH3PR11MB7390:EE_ X-MS-Office365-Filtering-Correlation-Id: 843c9460-1a22-4ba7-6c13-08dd0278c837 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YytoaG0wWkhhdE5zMWdkVHM2azdINGwwZ2ZKYUNVemk2UHFqQVZick04eFA2?= =?utf-8?B?Y3lVb2JPK1FiY2tteWlFVm9DZmZLSDFCT0FaU0hiQUswb1pGbElvM3N6Z1ov?= =?utf-8?B?ZnAwQlZvOGFDWlFrYit6blEwQTVTdVJaMHR2ZmFzejlsVmIrVTRpQ0RJdGpR?= =?utf-8?B?dDVFYzZKUlFwdWdlZ2NZRUJucjVCcGYxOVBGVEt1UVExUjdrVEltam4yeGFO?= =?utf-8?B?cmVpMDhLY3lkY08wMmZuZlRqM1lNK0w1YThUTCtiUXpLZXREWXl3Z0drbzlG?= =?utf-8?B?RlE4N1I5MXRraUFqZWNJcENjcWloa1VXeHlqZFRoUFNnSERDSHIwOXc1cWhN?= =?utf-8?B?V0tKT0NwZ0tKczlFZll4WmpOVUgxZ1d4Y0hybVRiWEgwVTVicTZoeWdCMng0?= =?utf-8?B?YXVGL002SUExTjM2VFdDa0ZQdjBqVGRld1BxT1Vtd3g0L2tJWkNraE9pNXRW?= =?utf-8?B?WlNzTUZRTTdOTzFTSC9KY2xSMU9BSEZucURxeGZ6YlRObExRNFN1RDhYSmtJ?= =?utf-8?B?dUlRK3lkLzFiUEVQYzBOOWgxUVZBL3N5Z1UzOTlkK1NHTitNempJL0hFZGZv?= =?utf-8?B?VlFWZmhscmwzUTBzSEJ4NEI4NkZadUgyT3piWGZUdCtpUTVmS0NvRHhaUGJN?= =?utf-8?B?Tjd2YjdWeWNTVEVrWHlZWkwwQzM2NGo0U3JVMS9jS29aU0RlbkY3dWhndHJK?= =?utf-8?B?ZW5FbFZZMUxwOWtLNUtsQUFGNVZoMERYa0VpcVdrY1hxMXpPOWdFRmE1WGU1?= =?utf-8?B?YTRHSmY5c1p0ZDBtK1k0eUVsY054UU45R1RUTHBxcEhmWW42RWI5S2UyMUxR?= =?utf-8?B?SGJBL2pRemtXRVM5MWxjdURBSTJBZHY5WWt0bmVVOVRoNStBYURCejhWbWh0?= =?utf-8?B?dXQrRHZlVG1vUlg0ODZoeXdJVHZldmt1Q2gxNFFscHNudllvVGgrdWd1WTZp?= =?utf-8?B?MnRiNytYajZtY1B6ZTcxanhFNFdqSjVoUTlmWDBNclFXY29zSnlYTStoUHlM?= =?utf-8?B?M2xqd0lIYUVLWkQzU2VBa0RDVUtJOHBvV1FPWTVwZTNDbTF1U1RsemI4YW9Q?= =?utf-8?B?aWVKZVhOMDhVR21UQUFKTUZTcGFFMExld1ZzcUhxZTNKVDJnUHQvZ1huMno1?= =?utf-8?B?RCtlZ2RpNmtpVVJWdHlJbXc3Ui9YSkd6V2RPWXR5SGNrcENwZUhIZjJtMjNs?= =?utf-8?B?R2lKaVVnUUNxb1dKTEFtTDhhclI2eWhjb0J5RzFDWGtyQk9PeXpMeUNvNVJK?= =?utf-8?B?UG1LVFcrajVqY1ZiZ1VGVXZ0cFBsWTlrU0F1T0lNdVA5QXlldlcyVUlCcTRp?= =?utf-8?B?RXkrL0J3ZWx6T2lkSXFqU3VyNkY2dlhiYTZpcDEvQ2E4dFhtL2Q2YWJXRUpD?= =?utf-8?B?TnhrSFpXVnVTVnRTN1JsUDIwcnRMcTc4QU5zZm56VHVzY0NYMVVNdVhmOEJo?= =?utf-8?B?b045VmVkMUhwbk5VbmdXYmdqTjhFRWFidHFLNUx0b2M4TEwrTVFxVlc3Y1lS?= =?utf-8?B?MnMwODZjaDVvNlJpVXlEejZhNTcrejNVUzRNT0dBRWNrd2ZBN2tlRmoxdnla?= =?utf-8?B?T2VwZ05rRkJIR1QwRnE0dVF1RHBxL0dHcjBwOE1IUVRrOWlpQmN5eFlONVhX?= =?utf-8?B?b1A0SG9EeTJyb3cxTXl0UkdWbHBJQnJNKzA5RldZZVUvKzh3VEpFdGlqNlhP?= =?utf-8?B?NW1CbmlES0RsQlBQa2dINStoaFJqNXpWMndjaHB6MFdvamhhckI5RWhWb2pk?= =?utf-8?Q?tDhvBTeCtCsS+wCgFwRsHPt7MOGjbJgfrx2uHHw?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5772.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0gvaEFKRU5CeEVMOHA2QTY0dzJwN0Qzdlp2dDY0WU1ERUgrdTZLNkVRRTFG?= =?utf-8?B?Smx6L2U4RVlCWHNZTzczbGNvVGwzZVhIdU8yY2phOWhFZFpPaVVvcjBWaGVv?= =?utf-8?B?QVdnVmNuTTZZUEhjVHpUa0lWdFZ6OHFZMyswYUFCS29HTUZ3enUweXphbHl3?= =?utf-8?B?b2c4bTN6cFBDR3RLL0tPQUxKWVhLbHhVQ3hQMXE5aWpVYUV0bDFLcy9rSGRW?= =?utf-8?B?UStNcnNXdzBwOFVyVTlKWnBQVVVpOGtzZFRGQnVNSDFENEdGUGFxVGZBTXJn?= =?utf-8?B?QU4wTkJYSXBhN1lUbkVWSk80K1A1L05pTGZmTFNCeFJRK1M1bFlnUk1Kem9T?= =?utf-8?B?bEU1WjBhUEhyT1FOajREYytRR1U5WmtWVi8xbDkxT3J2ajNGZDltZ3prTnM2?= =?utf-8?B?R005amI2VFE0ZUhHYlBrODZHNmhTUEF3MU4zTk1hNlZ5Q0xIRk1MaVpvbXJm?= =?utf-8?B?ZHFjUDFGZFJiVVNjYVJmdDIvU3J1QXlGN2ZFOGo2cDl0c0lsakNudUIrbXR3?= =?utf-8?B?YjlweHRpSTZGd3UyQStQaU9qUzBMb2hFbE1tNkVKcVdEb0syWm4wU1JmSCtn?= =?utf-8?B?emJjK3dpa3JCY0YveU50dW05d0lmcGxORVM5NTk1am82TW5venJLRlp3Y3l1?= =?utf-8?B?ekl1REllZnRHaVRJUHRLRVJWM1FuMDFzWVYrU0h6K0RVMWdWb3Rva29PcHRO?= =?utf-8?B?WkNhVnc2dUpGM0VQNUlZVHFrM2pOYlVJeFJXUWNlN2RPV1JsVUFmc3BBTGRF?= =?utf-8?B?Y2FoY2dHaGRpS2IwK0tHK3BZdGt4MFFwRzBIYzJMajVDQ3dmTUxGYkZoWU9a?= =?utf-8?B?WW00cWpPZjB0bWVXYzgxZi9NS0xqMVJUYmgyTHFyZ3FkSDJ3eHdCdzhpOU5E?= =?utf-8?B?SjZsdGsrTFpQWVdhKy9DVTRJbTJsdEROeVNuandIdEplNTQrckYrYjI3TzM3?= =?utf-8?B?cUZ5S3NWSnFNcW11Yld1ZDBzQzV4TmxmR09rbDlXOXVJNTh3amEwZFZSM3c3?= =?utf-8?B?emlkMy8rMlBlT0NQa0NNb05ieURvVXFTaFhvZnowSXhvL0M5bWZOSEwyVE1K?= =?utf-8?B?L3ZkQkNyTFFvbDhIV3lFOVVwbDRMMm5LWHdEdHA4YWhKLzBnbjFXZ2ErbGZZ?= =?utf-8?B?aFlYUmV5THhYQThUckdSVXFrMWRyR3hoUjdyZWlMbng4Y3JuZk95MVo4R2Nn?= =?utf-8?B?c05QTlRSNzlFclFwalVNUVY3TU5nNUU3RkFyelZRT0lkSjdwT2ZaV2luMUJH?= =?utf-8?B?Y0o0bFp0ZXlBQjVERWlqNnhhS1QwM2pSdjhERWNKZy90blZ1cUFDa1JuWkNS?= =?utf-8?B?bEVRZTU3eGtrWjVvNXdXaytuVWpnZitVQkttdHJ5MFlsOU5uUGZzZmM0NFd6?= =?utf-8?B?ZWlJODBHWnpZQmJFeWZTWlBjYjc3NmdrNHM2cXBWeUgzYjFTSDJWMGc3NS8y?= =?utf-8?B?dm9OTWR6SjRWUi9ucmZSWEJRa01lQU80clJkMFNZOTNzUkVZSVJueG5WMnk4?= =?utf-8?B?anU4V2hIdmQzWnlacjRHNm9WUS9QcDE2Uys4RjN4MG9BMDB1dUE1MUVHcGs2?= =?utf-8?B?aG9mZ3hMUWhvRFNTaFpnSkdVenVNRGpGZnFWM3JHR2U4Y2VxdnhwLzJMNnFr?= =?utf-8?B?SStNYTFjY2JaYTJVRUxuTjB2U0FoU0V6Y1c1MnUrTnBTRFdvUnFwQnRvK1lq?= =?utf-8?B?OTFwOHFFS2o5NGhSMVMvUlpETjlsaDlpMHkyMm9aTHBKODcvY2x6WjJobTZz?= =?utf-8?B?cXFtR3ptZVVXeGN3VWtkSXg0aXoxQ0FxNHFXUEtEaW1tTklGWjQvQXdDVGtG?= =?utf-8?B?cVZyTTdlYzNQRWRTcm1zVkFhSk51eVZXR011Njk2MVgxZE1EejVyL1psZkRM?= =?utf-8?B?NlUxUVhvMXAxNWRrSmtiSVo0ZnFZbWI4RS9jaUVsblI0NUZTT0FxRktwSVZG?= =?utf-8?B?MXBXWUttU3NTaVhGZ094cjZpVG40SUEvUVVJQmZzbHp1M0hnbXdSY3oyZ200?= =?utf-8?B?UDRmTndzWFNqT0FlTG93V2RXRUJWczRxTGZlcC9vV3dOcCthS2JzSkdPd01Z?= =?utf-8?B?dWVIS05tUGZOaENFTmxYTElBY052THZvM0d3ZzJiQ3ozTFBuY3Ura3pOZmhr?= =?utf-8?B?alhLSGpWM2gva0lLWXlqWEsxU1FLRjR4QzdkdTFjazN1N2pJZzIvOEVDc2JV?= =?utf-8?B?NkE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 843c9460-1a22-4ba7-6c13-08dd0278c837 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5772.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 17:46:33.7793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AE3E2kl/HOxM/0emY+Jy4IcGAH2+E9iveEY5mmu58Ej21YLEwE9/FZ4V+DsC/N6jg80/Fxdm8vi1LBHxRXxa0EPtr4zUSsqHuKz7mHRXtNc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7390 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Vladimir Medvedkin On 11/11/2024 16:42, Bruce Richardson wrote: > In the Tx prep function, the metadata checks were only checking the > packet length and ignoring the data length. For single-buffer packets we > can quickly check that the data length is the packet length. > > Fixes: 19ee91c6bd9a ("net/iavf: check illegal packet sizes") > Cc: stable@dpdk.org > > Reported-by: Padraig Connolly > Signed-off-by: Bruce Richardson > --- > drivers/net/iavf/iavf_rxtx.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c > index 4850b9e381..6a093c6746 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -3677,7 +3677,11 @@ iavf_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, > return i; > } > > - if (m->pkt_len < IAVF_TX_MIN_PKT_LEN) { > + /* valid packets are greater than min size, and single-buffer pkts > + * must have data_len == pkt_len > + */ > + if (m->pkt_len < IAVF_TX_MIN_PKT_LEN || > + (m->nb_segs == 1 && m->data_len != m->pkt_len)) { > rte_errno = EINVAL; > return i; > } -- Regards, Vladimir