DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Talal Irfan <talal.irfan@emumba.com>,
	adrien.mazarguil@6wind.com, thomas@monjalon.net
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 17.11] lib/librte_ether/rte_ethdev.c: Check device count
Date: Fri, 10 Apr 2020 11:37:59 +0100	[thread overview]
Message-ID: <1ad63e43-8dda-69ce-3951-4a483aea0d22@intel.com> (raw)
In-Reply-To: <20200407162523.6899-1-talal.irfan@emumba.com>

On 4/7/2020 5:25 PM, Talal Irfan wrote:
> Bugzilla ID: 6
> Cc: dev@dpdk.org
> Cc: Thomas Monjalon <thomas@monjalon.net>
> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Cc: stable@dpdk.org
> Reported-by: Wang Zhike <wangzhike@jd.com>
> Suggested-by: Vipin Varghese <vipin.varghese@intel.com>
> Signed-off-by: Talal Irfan <talal.irfan@emumba.com>
> ---
>  lib/librte_ether/rte_ethdev.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 318af2869..ac19baf0c 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -376,6 +376,12 @@ rte_eth_dev_attach(const char *devargs, uint16_t *port_id)
>  		goto err;
>  	}
>  
> +	if (current <= 0) {
> +		RTE_LOG(ERR, EAL, "No port found for device (%s)\n", name);
> +		ret = -EINVAL;
> +		goto err;
> +	}
> +
>  	/* parse devargs, then retrieve device name and args */
>  	if (rte_eal_parse_devargs_str(devargs, &name, &args))
>  		goto err;
> 

Hi Talal,

Thanks for the fix.

v17.11 support ended, and issue seems not valid for v18.11 and later [1], can
you please confirm this?
And if you confirm can you please close the mentioned defect?

Thanks,
ferruh

[1]
'rte_eth_dev_attach()' removed before v18.11 .

  reply	other threads:[~2020-04-10 10:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 16:25 Talal Irfan
2020-04-10 10:37 ` Ferruh Yigit [this message]
2020-04-10 10:56   ` [dpdk-dev] [dpdk-stable] " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1ad63e43-8dda-69ce-3951-4a483aea0d22@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=talal.irfan@emumba.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).