From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2E3B0A0547;
	Mon, 19 Apr 2021 03:03:51 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 11B364115B;
	Mon, 19 Apr 2021 03:03:51 +0200 (CEST)
Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])
 by mails.dpdk.org (Postfix) with ESMTP id 482D14115A
 for <dev@dpdk.org>; Mon, 19 Apr 2021 03:03:50 +0200 (CEST)
Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.60])
 by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FNpS21Y93zlXqf;
 Mon, 19 Apr 2021 09:01:54 +0800 (CST)
Received: from [10.67.103.128] (10.67.103.128) by
 DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id
 14.3.498.0; Mon, 19 Apr 2021 09:03:48 +0800
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
CC: <anatoly.burakov@intel.com>, <andrew.rybchenko@oktetlabs.ru>,
 <thomas@monjalon.net>, <xiaoyun.li@intel.com>
References: <1614906276-34293-1-git-send-email-oulijun@huawei.com>
 <1618639954-31365-1-git-send-email-humin29@huawei.com>
 <de1cdcbe-e170-d772-ffce-976dc4f67288@intel.com>
From: "Min Hu (Connor)" <humin29@huawei.com>
Message-ID: <1af98482-e365-12a8-7aba-8cb5cafa9e8c@huawei.com>
Date: Mon, 19 Apr 2021 09:03:48 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <de1cdcbe-e170-d772-ffce-976dc4f67288@intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.128]
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH v10] app/testpmd: support multi-process
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thanks Ferruh, fixed in v11, thanks.

在 2021/4/18 6:21, Ferruh Yigit 写道:
> On 4/17/2021 7:12 AM, Min Hu (Connor) wrote:
>> This patch adds multi-process support for testpmd.
>> The test cmd example as follows:
>> the primary cmd:
>> ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \
>> --rxq=4 --txq=4 --num-procs=2 --proc-id=0
>>
>> the secondary cmd:
>> ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \
>> --rxq=4 --txq=4 --num-procs=2 --proc-id=1
>>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
>> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> 
> Hi Connor,
> 
> I put some minor syntax comments, when they are fixed,
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> <...>
> 
>>               if (diag != 0) {
>> -                if (rte_atomic16_cmpset(&(port->port_status),
>> -                RTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0)
>> -                    printf("Port %d can not be set back "
>> -                            "to stopped\n", pi);
>> -                printf("Fail to configure port %d\n", pi);
>> +                if (rte_atomic16_cmpset(
>> +                        &(port->port_status),
>> +                        RTE_PORT_HANDLING,
>> +                        RTE_PORT_STOPPED) == 0)
>> +                    printf("Port %d can not be set "
>> +                           "back to stopped\n", pi);
> 
> It is OK to have long line for the strings, so it can be like
> printf("Port %d can not be set back to stopped\n",
>      pi);
> 
>> +                printf("Fail to configure port %d\n",
>> +                    pi);
> 
> No need to update this line.
> 
> <...>
> 
>>               /* Fail to setup rx queue, return */
>>               if (rte_atomic16_cmpset(&(port->port_status),
>> -                RTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0)
>> +            RTE_PORT_HANDLING, RTE_PORT_STOPPED) == 0)
>>                   printf("Port %d can not be set back to "
>> -                            "stopped\n", pi);
>> +                            "stopped\n",
>> +                    pi);
> 
> These are syntax changes, I think can keep these lines as it is.
> 
> .